Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update theme base style and update snapshots #5628

Merged
merged 4 commits into from
Apr 9, 2024
Merged

Conversation

yvonneyx
Copy link
Contributor

@yvonneyx yvonneyx commented Apr 8, 2024

  • 调整主题基础样式配置并更新截图

@yvonneyx yvonneyx changed the title refactor: update theme base config and update snapshots refactor: update theme base style and update snapshots Apr 8, 2024
Copy link
Contributor Author

@yvonneyx yvonneyx Apr 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

之前截图效果不对,更改后的正确。是由于之前的主题默认样式指定了 lineWidth 为 0 且未设置 stroke,当用户更改 node 样式 lineWidth 为 1 时由于没有设置颜色就没展示正确的外轮廓

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个有点差异

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mark

Copy link
Contributor

@Aarebecca Aarebecca Apr 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

蓝色的两个节点

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mark

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mark

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mark

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mark

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mark

@yvonneyx yvonneyx requested a review from Aarebecca April 9, 2024 08:05
@Aarebecca Aarebecca merged commit ba7caf3 into v5 Apr 9, 2024
3 of 5 checks passed
@Aarebecca Aarebecca deleted the refactor/theme branch April 9, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants