Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layer model和 shader 结构分组重构 #2154

Closed
6 of 7 tasks
lzxue opened this issue Dec 12, 2023 · 2 comments
Closed
6 of 7 tasks

layer model和 shader 结构分组重构 #2154

lzxue opened this issue Dec 12, 2023 · 2 comments
Assignees
Labels
AntV OSCP V3 L7 3.0 升级

Comments

@lzxue
Copy link
Contributor

lzxue commented Dec 12, 2023

AntV Open Source Contribution Plan(可选)

  • 我同意将这个 Issue 参与 OSCP 计划

Issue 类型

中级任务

任务介绍

重构规则

Model 和 shaders 一样对应,每个model 在 shaders 目录下 文件夹目录

  • models 对应 为 l7 shape 代表不同形状
    • line
    • arc
  • shaders
    • line
      • line_frag.glsl
      • line_vert.glsl
      • dash_frag.glsl
      • dash_vert.glsl
    • arc
      • line_frag.glsl
      • line_vert.glsl
      • dash_frag.glsl
      • dash_vert.glsl

目录划分

shader 按照 model 进行划分

  • line
  • arc
  • flow
  • simple

dash/linear 属于样式,不需要单独的model, 是不同 shape 的实现。

其他图层,点图层相对复杂,其他图层基本是目录的重构

修改图层

  • PointLayer 已认领
  • LineLayer 已认领
  • PolygonLayer
  • heatmap
  • earth 已认领
  • geometry

参考说明

No response

@lzxue lzxue added AntV OSCP V3 L7 3.0 升级 labels Dec 12, 2023
@lzxue lzxue changed the title layer model和 shader 目录结构重构 layer model和 shader 结构分组重构 Dec 12, 2023
@zhnny
Copy link
Contributor

zhnny commented Dec 12, 2023

认领 heatmap

@taiyuanhy
Copy link
Contributor

taiyuanhy commented Dec 12, 2023

认领Point,Line和earth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AntV OSCP V3 L7 3.0 升级
Development

No branches or pull requests

5 participants