Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode #40

Merged
merged 7 commits into from Oct 16, 2019
Merged

Encode #40

merged 7 commits into from Oct 16, 2019

Conversation

lzxue
Copy link
Contributor

@lzxue lzxue commented Oct 16, 2019

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Description of change

@todo
Copy link

todo bot commented Oct 16, 2019

support point light、spot light & sun light

// TODO: support point light、spot light & sun light
uniform float u_ambient : 1.0;
uniform float u_diffuse : 1.0;
uniform float u_specular : 1.0;
uniform int u_num_of_directional_lights : 1;
uniform int u_num_of_spot_lights : 0;


This comment was generated by todo based on a TODO comment in ae4a594 in #40. cc @antvis.

@todo
Copy link

todo bot commented Oct 16, 2019

merge 默认同类型

this.styleOption = options; // TODO: merge 默认同类型
return this;
}
public render(): ILayer {
if (this.multiPassRenderer && this.multiPassRenderer.getRenderFlag()) {
this.multiPassRenderer.render();


This comment was generated by todo based on a TODO comment in ae4a594 in #40. cc @antvis.

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@todo
Copy link

todo bot commented Oct 16, 2019

数据过滤

// TODO: 数据过滤
Object.keys(attributes).forEach((attributeName: string) => {
const attribute = attributes[attributeName];
// const { type } = attribute; // TODO: 支持常量 或变量
// if (type === StyleScaleType.CONSTANT) {
// return;


This comment was generated by todo based on a TODO comment in ae4a594 in #40. cc @antvis.

@todo
Copy link

todo bot commented Oct 16, 2019

支持常量 或变量

// const { type } = attribute; // TODO: 支持常量 或变量
// if (type === StyleScaleType.CONSTANT) {
// return;
// }
let values = this.getAttrValue(attribute, record);
if (attributeName === 'color') {


This comment was generated by todo based on a TODO comment in ae4a594 in #40. cc @antvis.

@todo
Copy link

todo bot commented Oct 16, 2019

用过BBox计算纹理坐标

// // TODO 用过BBox计算纹理坐标
// this.attributes.uv.set([-1, -1], (verticesOffset + i) * 2);
// }
}
bufferInfo.verticesOffset += pointCount;
// 添加顶点索引


This comment was generated by todo based on a TODO comment in ae4a594 in #40. cc @antvis.

@todo
Copy link

todo bot commented Oct 16, 2019

用过BBox计算纹理坐标

// // TODO 用过BBox计算纹理坐标
// this.attributes.uv.set(
// [0, 0, 1, 1, 1, 0, 0, 1, 1, 1, 0, 0],
// (verticesOffset + i) * 3,
// );
// }


This comment was generated by todo based on a TODO comment in ae4a594 in #40. cc @antvis.

@todo
Copy link

todo bot commented Oct 16, 2019

根据平面坐标计算距离

const lineDistance = lineSegmentDistance(cur, last); // TODO: 根据平面坐标计算距离
const d = lineDistance + attrDistance[attrDistance.length - 1];
direction(lineA, cur, last);
if (!lineNormal) {
lineNormal = vec2.create();
computeNormal(lineNormal, lineA);


This comment was generated by todo based on a TODO comment in ae4a594 in #40. cc @antvis.

@lzxue lzxue merged commit 26e898b into next Oct 16, 2019
@todo todo bot mentioned this pull request Oct 16, 2019
lzxue added a commit that referenced this pull request Mar 5, 2020
lzxue added a commit that referenced this pull request Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant