fix(spreadsheet): solve the workflow and test case (#286)

* fix(data-cell): cyccle dependence bugs (#269) * feat: add pointer cursor for link field text (#270) * chore(ci): ci enhance (#268) * chore(release): 🔖 publish new version v0.1.5 (#267) * chore: 🔥 remoce useless annotations * chore: change the build script * chore(release): 🔖 publish new version - @antv/s2@0.1.5 * chore(ci): pr test * chore(ci): assign * chore(ci): add issue ci * chore(ci): rename * chore(ci): badge * chore(ci): auto add reviwer * chore(ci): update lib link * chore(ci): fix lint error * chore: 🔧 update the site preview configuration * chore: 🔧 add preview workflows * chore: 🔧 update the site scripts * chore: 📝 update the tips info for the issue close and issue labeled * chore(ci): fix bundle size * chore(ci): update compressed size action * chore(ci): fix eslint ignore config * chore(ci): update action * chore(ci): auto add weekly label * chore(ci): update node version Co-authored-by: 嘤嘤嘤 <yingying.xwy@antgroup.com> * fix: replace circular deps (#271) * docs: update badge (#272) * docs: update badge * docs: fix access lint * test(dataset): finish dataset test (#265) * test(dataset): finish dataset test * fix(test): adjust unit jest-extended * test: add test timeout (#274) * test: add test timeout * test: fix lint * test: fix ci order * test: adjust pr label * test: add max worker * test: use macos runtime * fix: bundle file declaration generation (#276) * fix: bundle file declaration generation * fix: lint error * fix: revert set label action * fix: default export issue * fix: remove annotion * fix: faild test * fix: coverage * fix: trigger event * fix: output locv file * fix: base path * fix: use size limit * fix: adjust limit size * fix: use node 12 * fix: adjust size limit * fix: remove size limit action * fix: 🐛 solve the issue that the 'customHeaders' does not work (#277) * chore(test): ✅ fix the issue of checkbox of test * style: 💄 tweak the theme style * fix: 🐛 solve the issue that the 'customHeaders' does not work * chore: 📝 update the pull request template Co-authored-by: Jinke Li <a1231236677287@163.com> * fix: table mode pagination (#283) Co-authored-by: xinhui.zxh <xinhui.zxh@antgroup.com> * refactor: table sort feature (#273) * chore(release): 🔖 publish new version v0.1.5 (#267) * chore: 🔥 remoce useless annotations * chore: change the build script * chore(release): 🔖 publish new version - @antv/s2@0.1.5 * Create CNAME * feat: table sort refactor * feat: remove currentSortKey store Co-authored-by: 嘤嘤嘤 <yingying.xwy@antgroup.com> Co-authored-by: 嘤嘤嘤 <wanyingxing@gmail.com> Co-authored-by: wengyidong.wyd <wengyidong.wyd@alibaba-inc.com> Co-authored-by: Wenjun Xu <906626481@qq.com> Co-authored-by: Jinke Li <a1231236677287@163.com> Co-authored-by: 嘤嘤嘤 <yingying.xwy@antgroup.com> Co-authored-by: Xinhui <120797887@qq.com> Co-authored-by: xinhui.zxh <xinhui.zxh@antgroup.com> Co-authored-by: YardWill <YardWill@users.noreply.github.com> Co-authored-by: 嘤嘤嘤 <wanyingxing@gmail.com> Co-authored-by: wengyidong.wyd <wengyidong.wyd@alibaba-inc.com>
antvis · Sep 16, 2021 · c44e469 · c44e469
1 parent 6cd4cc9
commit c44e469
Show file tree

Hide file tree

Showing 71 changed files with 1,560 additions and 2,700 deletions.
diff --git a/.eslintignore b/.eslintignore
@@ -1,8 +1,10 @@
-s2-site/site/**/*.js
-packgaes/s2-core/dist
-packgaes/s2-core/lib
-packgaes/s2-core/esm
-packgaes/s2-core/dist/node_modules
+s2-site
 node_modules
 .cache
 package.json
+.history
+esm
+lib
+dist
+.idea
+*.d.ts
diff --git a/.eslintrc b/.eslintrc
@@ -44,7 +44,7 @@
       }
     ],
     "import/order": 2,
-    "import/no-default-export": 1,
+    "import/no-default-export": 2,
     "no-restricted-syntax": 0,
     "semi": 0,
     "no-console": 2,
@@ -64,10 +64,10 @@
         "allowForLoopAfterthoughts": true
       }
     ],
-    "class-methods-use-this": 0, // 不强制使用 this, 因为子类可能复写方法
-    "no-param-reassign": 0, // 允许参数更改值
-    "@typescript-eslint/no-empty-function": 0, // 允许空方法,(默认实现)
-    "@typescript-eslint/explicit-module-boundary-types": 0, // 允许无返回  值
+    "class-methods-use-this": 0,
+    "no-param-reassign": 0,
+    "@typescript-eslint/no-empty-function": 0,
+    "@typescript-eslint/explicit-module-boundary-types": 0,
     "import/no-named-default": 0,
     "react/jsx-filename-extension": [
       1,

diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
@@ -1,4 +1,4 @@
-### 🤔 PR includes
+### 👀 PR includes
 
 <!-- Add completed items in this PR, and change [ ] to [x]. -->
 
@@ -14,7 +14,7 @@
 - [ ] Improve performance.
 - [ ] Type optimization
 
-🐛 Bug fix
+🐛 Bugfix
 
 - [ ] Bug fix issue #0
 

diff --git a/.github/workflows/lint.yml → .github/workflows/ci.yml b/.github/workflows/lint.yml → .github/workflows/ci.yml
@@ -1,14 +1,15 @@
-name: 🔆 Lint
+name: CI
 
-on: [push]
+on: [push, pull_request]
 
 jobs:
   build:
-    runs-on: ubuntu-latest
+    runs-on: macos-latest
     if: "!contains(github.event.head_commit.message, '[ci skip]')"
     strategy:
       matrix:
-        node-version: [12.x, 14.x]
+        # node-version: [12.x, 14.x, 16.x]
+        node-version: [12.x]
 
     steps:
       - uses: actions/checkout@v2
@@ -33,8 +34,20 @@ jobs:
       - name: Install dependencies
         run: yarn
 
-      - name: Lint scripts type and style
+      - name: Lint scripts, type and style
         run: yarn lint
 
       - name: Build
         run: yarn build
+
+      - name: Test
+        run: |
+          yarn test:coverage
+        env:
+          CI: true
+
+      - name: Upload test coverage
+        uses: coverallsapp/github-action@master
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          path-to-lcov: './packages/s2-core/coverage/lcov.info'
diff --git a/.github/workflows/issue-close-require.yml b/.github/workflows/issue-close-require.yml
@@ -0,0 +1,28 @@
+
+name: Issue Close Require
+
+on:
+  schedule:
+    - cron: "0 0 * * *"
+
+jobs:
+  close-issues:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Need reproduce
+        uses: actions-cool/issues-helper@main
+        with:
+          actions: 'close-issues'
+          labels: '🤔 Need Reproduce'
+          inactive-day: 7
+          body: |
+            由于该 issue 被标记为需要复现，却 7 天未收到回应。现关闭 issue，若有任何问题，可评论回复。（Cause this issue was labeled as ‘need reproduce’ but received no replay in 7 days, it was going to be closed now. If you have any questions, feel free to comment.）
+
+      - name: Needs more info
+        uses: actions-cool/issues-helper@main
+        with:
+          actions: 'close-issues'
+          labels: '👀 need more info'
+          inactive-day: 7
+          body: |
+            由于该 issue 被标记为需要复现，却 7 天未收到回应。现关闭 issue，若有任何问题，可评论回复。（Cause this issue was labeled as ‘need reproduce’ but received no replay in 7 days, it was going to be closed now. If you have any questions, feel free to comment.）
diff --git a/.github/workflows/issue-labeled.yml b/.github/workflows/issue-labeled.yml
@@ -0,0 +1,60 @@
+name: Issue Labeled
+
+on:
+  issues:
+    types: [labeled]
+
+jobs:
+  reply-helper:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Need Reproduce
+        if: github.event.label.name == '🤔 Need Reproduce'
+        uses: actions-cool/issues-helper@main
+        with:
+          actions: 'create-comment'
+          token: ${{ secrets.GITHUB_TOKEN }}
+          issue-number: ${{ github.event.issue.number }}
+          body: |
+            你好 @${{ github.event.issue.user.login }}，请提供一个可以在线访问的链接, 或者使用[codesandbox](https://codesandbox.io/s/29zle) 并详细说明复现步骤, 7天内未回复issue自动关闭。（ Hello, @${{ github.event.issue.user.login }}, please provide an accessible link or use[codesandbox](https://codesandbox.io/s/29zle) to describe the step. It will be closed if we receive no replay in 7 days.
+            ）
+
+      - name: Need more info
+        if: github.event.label.name == '👀 need more info'
+        uses: actions-cool/issues-helper@main
+        with:
+          actions: 'create-comment'
+          token: ${{ secrets.GITHUB_TOKEN }}
+          issue-number: ${{ github.event.issue.number }}
+          body: |
+            你好 @${{ github.event.issue.user.login }}，你所提供的信息不足于我们排查问题, 请完善 issue 描述, 提供 gif, 截图等方式, 详细说明复现步骤, 感谢配合, 谢谢!(Hello, @${{ github.event.issue.user.login }}, the information you provided is not enough for us to trace the problem. Please complete the issue description, provide gifs, screenshots, etc. and explain the reproduction steps in detail. Thank you so much for being so cooperative!)
+
+      - name: Invalid
+        if: github.event.label.name == '⛔ invalid'
+        uses: actions-cool/issues-helper@main
+        with:
+          actions: 'create-comment,close-issue'
+          token: ${{ secrets.GITHUB_TOKEN }}
+          issue-number: ${{ github.event.issue.number }}
+          body: |
+            你好 @${{ github.event.issue.user.login }}，请按照 issue 模板填写相关信息, 方便大家高效沟通。(Hello @${{ github.event.issue.user.login }}, please fill in the relevant information according to the issue template, so that everyone can communicate efficiently. Thank you so much!)
+
+      - name: Enhancement
+        if: github.event.label.name == '⚡ enhancement'
+        uses: actions-cool/issues-helper@main
+        with:
+          actions: 'create-comment'
+          token: ${{ secrets.GITHUB_TOKEN }}
+          issue-number: ${{ github.event.issue.number }}
+          body: |
+            你好 @${{ github.event.issue.user.login }}，感谢你的建议, 我们会及时评估和排期, 谢谢!(Hello, @${{ github.event.issue.user.login }}, thanks for your advice. We will evaluate and schedule in time. Thank you!)
+
+      - name: Usage
+        if: github.event.label.name == '🙀 usage' || github.event.label.name == '❔question'
+        uses: actions-cool/issues-helper@main
+        with:
+          actions: 'create-comment,close-issue'
+          token: ${{ secrets.GITHUB_TOKEN }}
+          issue-number: ${{ github.event.issue.number }}
+          body: |
+            你好 @${{ github.event.issue.user.login }}，Issue 板块是用于 bug 反馈与需求讨论的地方。你可以试着在 [antv s2 discussions](https://github.com/antvis/S2/discussions) 新开一个 discussion，选择 `🙏Q&A` 类别进行提问, 我们会及时进行解答, 感谢你的理解。(Hello, @${{ github.event.issue.user.login }}.The Issue section is used for bug feedback and requirement discussion. You can try to open a new discussion in [antv s2 discussions](https://github.com/antvis/S2/discussions), choose the `🙏Q&A` category to ask questions, we will answer in time. Thank you so much for being so understanding)
diff --git a/.github/workflows/pr-auto-assign-reviewer.yml b/.github/workflows/pr-auto-assign-reviewer.yml
@@ -1,17 +1,25 @@
 name: 👨‍💻👩‍💻 PR Auto Assign Reviewer
 
 on:
-  pull_request:
-    types: [opened, edited]
+  pull_request_target:
+    types: [opened]
 
 jobs:
   add-reviewer:
     runs-on: ubuntu-latest
     steps:
-      - name: Add reviewer
+      - name: Add assignees
         uses: actions-cool/issues-helper@main
         with:
           actions: 'add-assignees'
           token: ${{ secrets.GITHUB_TOKEN }}
           issue-number: ${{ github.event.pull_request.number }}
-          assignees: 'xingwanying,qubaomingg,yangzhanmei,YardWill,lijinke666,wjgogogo,zxc0328'
+          assignees: ${{ github.event.pull_request.user.login }}
+
+      - name: Add reviewers
+        uses: actions-cool/pr-welcome@main
+        with:
+          token: ${{ secrets.GITHUB_TOKEN }}
+          emoji: '+1'
+          reviewers: 'xingwanying,qubaomingg,yangzhanmei,YardWill,lijinke666,wjgogogo,zxc0328'
+          excludeReviewers: ${{ github.event.pull_request.user.login }}
diff --git a/.github/workflows/pr-auto-set-label.yml b/.github/workflows/pr-auto-set-label.yml
@@ -1,7 +1,7 @@
 name: 🏷 PR Auto Set Label
 
 on:
-  pull_request:
+  pull_request_target:
     types: [opened, edited]
 
 jobs:
@@ -61,3 +61,21 @@ jobs:
           token: ${{ secrets.GITHUB_TOKEN }}
           issue-number: ${{ github.event.pull_request.number }}
           labels: 'pr(documentation)'
+
+      - name: Set refactor label
+        if: startsWith(github.event.pull_request.title, 'refactor')
+        uses: actions-cool/issues-helper@main
+        with:
+          actions: 'set-labels'
+          token: ${{ secrets.GITHUB_TOKEN }}
+          issue-number: ${{ github.event.pull_request.number }}
+          labels: 'pr(refactor)'
+
+      - name: Set weekly label
+        if: contains(github.event.pull_request.head.ref, 'weekly')
+        uses: actions-cool/issues-helper@main
+        with:
+          actions: 'set-labels'
+          token: ${{ secrets.GITHUB_TOKEN }}
+          issue-number: ${{ github.event.pull_request.number }}
+          labels: '🗓 weekly'
diff --git a/.github/workflows/pr-notify.yml b/.github/workflows/pr-notify.yml
@@ -1,14 +1,13 @@
 name: 🔊 PR Ding Talk Notify
 
 on:
-  pull_request:
+  pull_request_target:
     types: [opened]
 
 jobs:
   preview:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
       - name: Ding Talk PR Notify
         uses: lijinke666/ding-talk-pr-notify@main
         with:

diff --git a/.github/workflows/preview-build.yml b/.github/workflows/preview-build.yml
@@ -0,0 +1,36 @@
+name: Preview Build
+
+on: 
+  pull_request:
+    types: [opened, synchronize, reopened]
+
+jobs:
+  build-preview:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v2
+        with:
+          ref: ${{ github.event.pull_request.head.sha }}
+
+      - name: build
+        run: |
+          yarn run site:bootstrap
+          yarn run site:build
+      - name: upload dist artifact
+        uses: actions/upload-artifact@v2
+        with:
+          name: dist
+          path: s2-site/public/
+          retention-days: 5
+
+      - name: Save PR number
+        if: ${{ always() }}
+        run: echo ${{ github.event.number }} > ./pr-id.txt
+
+      - name: Upload PR number
+        if: ${{ always() }}
+        uses: actions/upload-artifact@v2
+        with:
+          name: pr
+          path: ./pr-id.txt
diff --git a/.github/workflows/preview-deploy.yml b/.github/workflows/preview-deploy.yml
@@ -0,0 +1,83 @@
+name: Preview Deploy
+
+on:
+  workflow_run:
+    workflows: ["Preview Build"]
+    types:
+      - completed
+
+jobs:
+  success:
+    runs-on: ubuntu-latest
+    if: github.event.workflow_run.event == 'pull_request' && github.event.workflow_run.conclusion == 'success'
+    steps:
+      - name: download pr artifact
+        uses: dawidd6/action-download-artifact@v2
+        with:
+          workflow: ${{ github.event.workflow_run.workflow_id }}
+          name: pr
+
+      - name: save PR id
+        id: pr
+        run: echo "::set-output name=id::$(<pr-id.txt)"
+
+      - name: download dist artifact
+        uses: dawidd6/action-download-artifact@v2
+        with:
+          workflow: ${{ github.event.workflow_run.workflow_id }}
+          workflow_conclusion: success
+          name: dist
+
+      - name: upload surge service
+        id: deploy
+        run: |
+          export DEPLOY_DOMAIN=https://gatsby-theme-preview-pr-${{ steps.pr.outputs.id }}.surge.sh
+          npx surge --project ./ --domain $DEPLOY_DOMAIN --token ${{ secrets.SURGE_TOKEN }}
+      - name: update status comment
+        uses: actions-cool/maintain-one-comment@v1.1.0
+        with:
+          token: ${{ secrets.GITHUB_TOKEN }}
+          body: |
+            🎊 PR Preview has been successfully built and deployed to https://gatsby-theme-preview-pr-${{ steps.pr.outputs.id }}.surge.sh
+            
+            <img width="300" src="https://user-images.githubusercontent.com/507615/90250366-88233900-de6e-11ea-95a5-84f0762ffd39.png">
+            <!-- Sticky Pull Request Comment -->
+          body-include: '<!-- Sticky Pull Request Comment -->'
+          number: ${{ steps.pr.outputs.id }}
+
+      - name: The job failed
+        if: ${{ failure() }}
+        uses: actions-cool/maintain-one-comment@v1.1.0
+        with:
+          token: ${{ secrets.GITHUB_TOKEN }}
+          body: |
+            😭 Deploy PR Preview failed.
+            <img width="300" src="https://user-images.githubusercontent.com/507615/90250824-4e066700-de6f-11ea-8230-600ecc3d6a6b.png">
+            <!-- Sticky Pull Request Comment -->
+          body-include: '<!-- Sticky Pull Request Comment -->'
+          number: ${{ steps.pr.outputs.id }}
+
+  failed:
+    runs-on: ubuntu-latest
+    if: github.event.workflow_run.event == 'pull_request' && github.event.workflow_run.conclusion == 'failure'
+    steps:
+      - name: download pr artifact
+        uses: dawidd6/action-download-artifact@v2
+        with:
+          workflow: ${{ github.event.workflow_run.workflow_id }}
+          name: pr
+
+      - name: save PR id
+        id: pr
+        run: echo "::set-output name=id::$(<pr-id.txt)"
+
+      - name: The job failed
+        uses: actions-cool/maintain-one-comment@v1.1.0
+        with:
+          token: ${{ secrets.GITHUB_TOKEN }}
+          body: |
+            😭 Deploy PR Preview failed.
+            <img width="300" src="https://user-images.githubusercontent.com/507615/90250824-4e066700-de6f-11ea-8230-600ecc3d6a6b.png">
+            <!-- Sticky Pull Request Comment -->
+          body-include: '<!-- Sticky Pull Request Comment -->'
+          number: ${{ steps.pr.outputs.id }}