Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: table sort feature #273

Merged
merged 5 commits into from Sep 16, 2021
Merged

refactor: table sort feature #273

merged 5 commits into from Sep 16, 2021

Conversation

YardWill
Copy link
Member

πŸ€” PR includes

✨ Feature

  • table sort refactor

πŸ“ Description

Use sortParams to implement table sort

πŸ”— Related issue link

#263

xingwanying and others added 3 commits September 13, 2021 17:40
* chore: πŸ”₯ remoce useless annotations

* chore: change the build script

* chore(release): πŸ”– publish new version

 - @antv/s2@0.1.5
@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2021

⚑️ Deploying PR Preview...

@github-actions
Copy link
Contributor

Size Change: +56 B (0%)

Total Size: 113 kB

Filename Size Change
./packages/s2-core/dist/s2.min.js 111 kB +56 B (0%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/s2.min.css 1.7 kB

compressed-size-action

Copy link
Member

@xingwanying xingwanying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prζ ‡ι’˜δΈη¬¦εˆθ§„θŒƒε—·ο½ž

CNAME Show resolved Hide resolved
@YardWill YardWill changed the title Table sort refactor: table sort feature Sep 14, 2021
Copy link
Member

@xingwanying xingwanying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@xingwanying xingwanying merged commit 7fefd6e into weekly-0913 Sep 16, 2021
@xingwanying xingwanying deleted the table-sort branch September 16, 2021 02:45
xingwanying added a commit that referenced this pull request Sep 16, 2021
* fix(data-cell): cyccle dependence bugs (#269)

* feat: add pointer cursor for link field text (#270)

* chore(ci): ci enhance (#268)

* chore(release): πŸ”– publish new version v0.1.5 (#267)

* chore: πŸ”₯ remoce useless annotations

* chore: change the build script

* chore(release): πŸ”– publish new version

 - @antv/s2@0.1.5

* chore(ci): pr test

* chore(ci): assign

* chore(ci): add issue ci

* chore(ci): rename

* chore(ci): badge

* chore(ci): auto add reviwer

* chore(ci): update lib link

* chore(ci): fix lint error

* chore: πŸ”§ update the site preview configuration

* chore: πŸ”§ add preview workflows

* chore: πŸ”§ update the site scripts

* chore: πŸ“ update the tips info for the issue close and issue labeled

* chore(ci): fix bundle size

* chore(ci): update compressed size action

* chore(ci): fix eslint ignore config

* chore(ci): update action

* chore(ci): auto add weekly label

* chore(ci): update node version

Co-authored-by: 嘀嘀嘀 <yingying.xwy@antgroup.com>

* fix: replace circular deps (#271)

* docs: update badge (#272)

* docs: update badge

* docs: fix access lint

* test(dataset): finish dataset test (#265)

* test(dataset): finish dataset test

* fix(test): adjust unit jest-extended

* test: add test timeout (#274)

* test: add test timeout

* test: fix lint

* test: fix ci order

* test: adjust pr label

* test: add max worker

* test: use macos runtime

* fix: bundle file declaration generation (#276)

* fix: bundle file declaration generation

* fix: lint error

* fix: revert set label action

* fix: default export issue

* fix: remove annotion

* fix: faild test

* fix: coverage

* fix: trigger event

* fix: output locv file

* fix: base path

* fix: use size limit

* fix: adjust limit size

* fix: use node 12

* fix: adjust size limit

* fix: remove size limit action

* fix: πŸ› solve the issue that the 'customHeaders' does not work (#277)

* chore(test): βœ… fix the issue of checkbox of test

* style: πŸ’„ tweak the theme style

* fix: πŸ› solve the issue that the 'customHeaders' does not work

* chore: πŸ“ update the pull request template

Co-authored-by: Jinke Li <a1231236677287@163.com>

* fix: table mode pagination (#283)

Co-authored-by: xinhui.zxh <xinhui.zxh@antgroup.com>

* refactor: table sort feature (#273)

* chore(release): πŸ”– publish new version v0.1.5 (#267)

* chore: πŸ”₯ remoce useless annotations

* chore: change the build script

* chore(release): πŸ”– publish new version

 - @antv/s2@0.1.5

* Create CNAME

* feat: table sort refactor

* feat: remove currentSortKey store

Co-authored-by: 嘀嘀嘀 <yingying.xwy@antgroup.com>
Co-authored-by: 嘀嘀嘀 <wanyingxing@gmail.com>
Co-authored-by: wengyidong.wyd <wengyidong.wyd@alibaba-inc.com>

Co-authored-by: Wenjun Xu <906626481@qq.com>
Co-authored-by: Jinke Li <a1231236677287@163.com>
Co-authored-by: 嘀嘀嘀 <yingying.xwy@antgroup.com>
Co-authored-by: Xinhui <120797887@qq.com>
Co-authored-by: xinhui.zxh <xinhui.zxh@antgroup.com>
Co-authored-by: YardWill <YardWill@users.noreply.github.com>
Co-authored-by: 嘀嘀嘀 <wanyingxing@gmail.com>
Co-authored-by: wengyidong.wyd <wengyidong.wyd@alibaba-inc.com>
wjgogogo added a commit that referenced this pull request Oct 25, 2023
* fix(data-cell): cyccle dependence bugs (#269)

* feat: add pointer cursor for link field text (#270)

* chore(ci): ci enhance (#268)

* chore(release): πŸ”– publish new version v0.1.5 (#267)

* chore: πŸ”₯ remoce useless annotations

* chore: change the build script

* chore(release): πŸ”– publish new version

 - @antv/s2@0.1.5

* chore(ci): pr test

* chore(ci): assign

* chore(ci): add issue ci

* chore(ci): rename

* chore(ci): badge

* chore(ci): auto add reviwer

* chore(ci): update lib link

* chore(ci): fix lint error

* chore: πŸ”§ update the site preview configuration

* chore: πŸ”§ add preview workflows

* chore: πŸ”§ update the site scripts

* chore: πŸ“ update the tips info for the issue close and issue labeled

* chore(ci): fix bundle size

* chore(ci): update compressed size action

* chore(ci): fix eslint ignore config

* chore(ci): update action

* chore(ci): auto add weekly label

* chore(ci): update node version

Co-authored-by: 嘀嘀嘀 <yingying.xwy@antgroup.com>

* fix: replace circular deps (#271)

* docs: update badge (#272)

* docs: update badge

* docs: fix access lint

* test(dataset): finish dataset test (#265)

* test(dataset): finish dataset test

* fix(test): adjust unit jest-extended

* test: add test timeout (#274)

* test: add test timeout

* test: fix lint

* test: fix ci order

* test: adjust pr label

* test: add max worker

* test: use macos runtime

* fix: bundle file declaration generation (#276)

* fix: bundle file declaration generation

* fix: lint error

* fix: revert set label action

* fix: default export issue

* fix: remove annotion

* fix: faild test

* fix: coverage

* fix: trigger event

* fix: output locv file

* fix: base path

* fix: use size limit

* fix: adjust limit size

* fix: use node 12

* fix: adjust size limit

* fix: remove size limit action

* fix: πŸ› solve the issue that the 'customHeaders' does not work (#277)

* chore(test): βœ… fix the issue of checkbox of test

* style: πŸ’„ tweak the theme style

* fix: πŸ› solve the issue that the 'customHeaders' does not work

* chore: πŸ“ update the pull request template

Co-authored-by: Jinke Li <a1231236677287@163.com>

* fix: table mode pagination (#283)

Co-authored-by: xinhui.zxh <xinhui.zxh@antgroup.com>

* refactor: table sort feature (#273)

* chore(release): πŸ”– publish new version v0.1.5 (#267)

* chore: πŸ”₯ remoce useless annotations

* chore: change the build script

* chore(release): πŸ”– publish new version

 - @antv/s2@0.1.5

* Create CNAME

* feat: table sort refactor

* feat: remove currentSortKey store

Co-authored-by: 嘀嘀嘀 <yingying.xwy@antgroup.com>
Co-authored-by: 嘀嘀嘀 <wanyingxing@gmail.com>
Co-authored-by: wengyidong.wyd <wengyidong.wyd@alibaba-inc.com>

Co-authored-by: Wenjun Xu <906626481@qq.com>
Co-authored-by: Jinke Li <a1231236677287@163.com>
Co-authored-by: 嘀嘀嘀 <yingying.xwy@antgroup.com>
Co-authored-by: Xinhui <120797887@qq.com>
Co-authored-by: xinhui.zxh <xinhui.zxh@antgroup.com>
Co-authored-by: YardWill <YardWill@users.noreply.github.com>
Co-authored-by: 嘀嘀嘀 <wanyingxing@gmail.com>
Co-authored-by: wengyidong.wyd <wengyidong.wyd@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants