Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix invalid contributing step #829

Merged
merged 1 commit into from
Nov 26, 2021
Merged

docs: fix invalid contributing step #829

merged 1 commit into from
Nov 26, 2021

Conversation

lijinke666
Copy link
Member

@lijinke666 lijinke666 commented Nov 26, 2021

👀 PR includes

✨ Feature

  • New feature

🎨 Enhance

  • Code style optimization
  • Refactoring
  • Change the UI
  • Improve the performance
  • Type optimization

🐛 Bugfix

  • Solve the issue and close #0

🔧 Chore

  • Test case
  • Docs / demos update
  • CI / workflow
  • Release version
  • Other ()

📝 Description

  1. 修改错误的贡献指南步骤, 应该是大写的 S2
    image
  2. 优化部分文档细节

🔗 Related issue link

🔍 Self Check before Merge

  • Add or update relevant Docs.
  • Add or update relevant Demos.
  • Add or update relevant TypeScript definitions.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2021

🎊 PR Preview has been successfully built and deployed to https://s2-preview-pr-829.surge.sh

@github-actions
Copy link
Contributor

Size Change: 0 B

Total Size: 184 kB

ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/index.min.js 112 kB
./packages/s2-core/dist/style.min.css 356 B
./packages/s2-react/dist/index.min.js 67.9 kB
./packages/s2-react/dist/style.min.css 3.1 kB

compressed-size-action

@codecov
Copy link

codecov bot commented Nov 26, 2021

Codecov Report

Merging #829 (e03f5d2) into master (c4413c9) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #829      +/-   ##
==========================================
+ Coverage   70.86%   70.94%   +0.08%     
==========================================
  Files         166      166              
  Lines       11541    11541              
  Branches     2702     2702              
==========================================
+ Hits         8178     8188      +10     
+ Misses       2216     2212       -4     
+ Partials     1147     1141       -6     
Impacted Files Coverage Δ
packages/s2-core/src/facet/base-facet.ts 68.83% <0.00%> (+2.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4413c9...e03f5d2. Read the comment docs.

@xrkffgg xrkffgg merged commit 9428927 into master Nov 26, 2021
@xrkffgg xrkffgg deleted the fix-doc branch November 26, 2021 06:57
@github-actions
Copy link
Contributor

🎉 This PR is included in version @antv/s2-v1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

🎉 This PR is included in version @antv/s2-v1.0.0-beta.17 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants