fix: 修复 axis rerender 不更新布局和 labelOffset 报错 #1293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request fixes 2 alerts when merging 36d6a03 into fddc32b - view on LGTM.com fixed alerts:
|
ACERY1
reviewed
Nov 29, 2021
|
|
||
| // 增量更新，以最大的宽高作为限制 | ||
| if (maxBBox) { | ||
| bbox = { |
There was a problem hiding this comment.
这段逻辑如果去掉的话, 如果多次update 会导致Chart里的layout越来越小
There was a problem hiding this comment.
具体可以跑下 packages/f2/test/components/interaction/pan.test.tsx 这个用例复现出来
There was a problem hiding this comment.
改好了，这个是update 时 坐标轴没有重置导致的
|
This pull request fixes 2 alerts when merging 764d236 into e0d4bab - view on LGTM.com fixed alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesDescription of change