fix：修复宽高改变的情况 #1507
Merged
fix：修复宽高改变的情况 #1507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zengyue
reviewed
Jun 7, 2022
packages/f2/src/canvas/index.ts
Outdated
| @@ -147,10 +147,39 @@ class Canvas extends Component<ChartProps> { | |||
| if (equal(nextProps, props)) { | |||
| return; | |||
| } | |||
| this.props = nextProps; | |||
|
|
|||
| this.props = deepMix({}, props, nextProps); | |||
There was a problem hiding this comment.
这里不用 mix, 直接 this.props = nextProps 就好了，这是全量更新
|
This pull request introduces 1 alert when merging f381e34 into bf4e870 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging a9e1f75 into bf4e870 - view on LGTM.com new alerts:
|
tangying1027
force-pushed
the
fix_bug
branch
2 times, most recently
from
c652e52
to
b6b875c
Compare
|
This pull request introduces 1 alert when merging b6b875c into bf4e870 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 447e3ab into bf4e870 - view on LGTM.com new alerts:
|
|
f2-react 可以同步支持吗，props 变化时，内部调用 canvas.resize() |
|
可以在f2-react那边获取canvas实例，然后调用 |
|
是的，不过如果可以内部封装掉，API 上对 react 更加友好一些 |
|
请问有ref.current.resize()的用法吗？ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesDescription of change