Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix legend filter bug on case line demo #3116

Merged
merged 1 commit into from
Dec 17, 2020
Merged

Conversation

lessmost
Copy link
Member

@lessmost lessmost commented Dec 15, 2020

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Description of change

https://g2.antv.vision/zh/examples/case/line#line8 因为自定义 Shape 写法不规范,导致图形在更新的时候好出错,将进一步导致如图例筛选等交互无法使用,这里更正下 DEMO 中的自定义 Shape 写法。

@lgtm-com
Copy link

lgtm-com bot commented Dec 15, 2020

This pull request fixes 1 alert when merging b4f6968 into f373965 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@github-actions
Copy link

github-actions bot commented Dec 15, 2020

😭 Deploy PR Preview b4f6968 failed. Build logs

🤖 By surge-preview

@coveralls
Copy link

Pull Request Test Coverage Report for Build 423186292

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 93.441%

Totals Coverage Status
Change from base Build 422364806: 0.07%
Covered Lines: 10674
Relevant Lines: 11078

💛 - Coveralls

@hustcc hustcc merged commit b316570 into master Dec 17, 2020
@hustcc hustcc deleted the fix-custom-shape-line branch December 17, 2020 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants