Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

feat: 增加i18n provider #12

Merged
merged 2 commits into from
Nov 6, 2019
Merged

feat: 增加i18n provider #12

merged 2 commits into from
Nov 6, 2019

Conversation

Jeffy2012
Copy link
Contributor

增加 i18n provider

ChartCube 这种只引入 Header Footer的 需要用 withProvider包装一下

import LHeader from '@antv/gatsby-theme-antv/lib/components/Header';
import LFooter from '@antv/gatsby-theme-antv/lib/components/Footer';
import withProivder from '@antv/gatsby-theme-antv/lib/components/withProvider';

const Header = withProivder(LHeader);
const Footer = withProivder(LFooter);

@auto-add-label auto-add-label bot added the enhancement New feature or request label Nov 6, 2019
@netlify
Copy link

netlify bot commented Nov 6, 2019

Deploy preview for gatsby-theme-antv ready!

Built with commit aaf700c

https://deploy-preview-12--gatsby-theme-antv.netlify.com

},
});

export default function witProvider<T>(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

withProvider ?

@@ -69,4 +69,4 @@ yarn-error.log
.yarn-integrity

.tmp
@antv/gatsby-theme-antv/components
@antv/gatsby-theme-antv/lib
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为啥要改成 lib。

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

知道了 withProvider 不是 components。

  1. 可以把 withProvider 放到 Header 里面去。
  2. 或者不用管,不是 components 就不是。

@afc163 afc163 merged commit aba1f3a into antvis:master Nov 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request PR: merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants