Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(extended): fix extended algorithm Infinite loop for NaN #142

Merged
merged 3 commits into from
May 12, 2021

Conversation

yuzhanglong
Copy link
Member

@yuzhanglong yuzhanglong commented May 11, 2021

fix antvis/G2#3413

  • fix extended algorithm Infinite loop for NaN

@yuzhanglong yuzhanglong changed the title fix: fix extended algorithm Infinite loop for NaN fix(extended): fix extended algorithm Infinite loop for NaN May 11, 2021
@hustcc
Copy link
Member

hustcc commented May 11, 2021

这次先通过。

720b4f2 提出问题:diff 太多,cr 成本高了~

主要是在这个 pr 中做了一些命名重构,代码写法重构,建议:

  1. 分 commit 进行处理(比如一个 commit 进行修复,一个 commit 进行重构)
  2. 分 pr 处理(先 pr 解决掉对应的 issue,然后再一个 pr 去重构)

都是为了降低 cr 的成本,cr 可以直接按照 pr 的 files,也可以按照 commit(重构命名和写法,可以一带而过),但是如果混杂一起,那就不太好搞。

@hustcc hustcc merged commit 064ac4f into v0.3.x May 12, 2021
@hustcc hustcc deleted the extended-fix branch May 12, 2021 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants