forked from apache/kafka
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
KAFKA-13328, KAFKA-13329 (1): Add preflight validations for key, valu…
…e, and header converter classes (apache#14304) Reviewers: Yash Mayya <yash.mayya@gmail.com>, Greg Harris <greg.harris@aiven.io>
- Loading branch information
1 parent
76db5fc
commit 1e20ce3
Showing
6 changed files
with
337 additions
and
41 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48 changes: 48 additions & 0 deletions
48
connect/runtime/src/main/java/org/apache/kafka/connect/util/ConcreteSubClassValidator.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.kafka.connect.util; | ||
|
|
||
| import org.apache.kafka.common.config.ConfigDef; | ||
| import org.apache.kafka.common.utils.Utils; | ||
|
|
||
| public class ConcreteSubClassValidator implements ConfigDef.Validator { | ||
| private final Class<?> expectedSuperClass; | ||
|
|
||
| private ConcreteSubClassValidator(Class<?> expectedSuperClass) { | ||
| this.expectedSuperClass = expectedSuperClass; | ||
| } | ||
|
|
||
| public static ConcreteSubClassValidator forSuperClass(Class<?> expectedSuperClass) { | ||
| return new ConcreteSubClassValidator(expectedSuperClass); | ||
| } | ||
|
|
||
| @Override | ||
| public void ensureValid(String name, Object value) { | ||
| if (value == null) { | ||
| // The value will be null if the class couldn't be found; no point in performing follow-up validation | ||
| return; | ||
| } | ||
|
|
||
| Class<?> cls = (Class<?>) value; | ||
| Utils.ensureConcreteSubclass(expectedSuperClass, cls); | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| return "A concrete subclass of " + expectedSuperClass.getName(); | ||
| } | ||
| } |
47 changes: 47 additions & 0 deletions
47
connect/runtime/src/main/java/org/apache/kafka/connect/util/InstantiableClassValidator.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.kafka.connect.util; | ||
|
|
||
| import org.apache.kafka.common.config.ConfigDef; | ||
| import org.apache.kafka.common.config.ConfigException; | ||
| import org.apache.kafka.common.utils.Utils; | ||
|
|
||
| public class InstantiableClassValidator implements ConfigDef.Validator { | ||
|
|
||
| @Override | ||
| public void ensureValid(String name, Object value) { | ||
| if (value == null) { | ||
| // The value will be null if the class couldn't be found; no point in performing follow-up validation | ||
| return; | ||
| } | ||
|
|
||
| Class<?> cls = (Class<?>) value; | ||
| try { | ||
| Object o = cls.getDeclaredConstructor().newInstance(); | ||
| Utils.maybeCloseQuietly(o, o + " (instantiated for preflight validation"); | ||
| } catch (NoSuchMethodException | IllegalAccessException e) { | ||
| throw new ConfigException(name, cls.getName(), "Could not find a public no-argument constructor for class" + (e.getMessage() != null ? ": " + e.getMessage() : "")); | ||
| } catch (ReflectiveOperationException | LinkageError | RuntimeException e) { | ||
| throw new ConfigException(name, cls.getName(), "Could not instantiate class" + (e.getMessage() != null ? ": " + e.getMessage() : "")); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| return "A class with a public, no-argument constructor"; | ||
| } | ||
| } |
Oops, something went wrong.