-
-
Notifications
You must be signed in to change notification settings - Fork 22.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a functionality that inherits background of repo card according to git-hub dark/light mode #777
Comments
You may provide The colour form like I think, maybe it's a good idea to support colour form like |
Yeah, we can use transparent background, but suppose if someone using black text color, then if he/she switches between modes, then black text makes the problem with the dark mode because black text color is barely visible in dark mode. I think providing functionality to users will be more efficient. |
it's not possible to detect if users is using dark/light. Only good way is to use a transparent color background and use text color which looks good on both light/dark mode. see #690 |
ok @anuraghazra sir got it. But sir, I have one question that, can we able to detect if a user is using dark/white with the background color. |
As i said no it's not possible to detect which theme user is using yet checkout the full discussion for more info: #690 |
Related to #739 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
I want a feature that whenever users switch between GitHub dark-light mode, then the background of the repo card changes accordingly to the mode. Means if a user wants a specific theme in dark or white mode, then whenever he/she switches between modes the theme sets accordingly GitHub mode. In simple words, the repo card's background inherits the background color of the applied mode.
Describe the solution you'd like
one possible solution to this issue is that we can simply set the background color same as the Github's mode's backgrounds by just apply an if statement that when mode = light set the background color to this.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
And the other possible solution is that we can give control to the user that he/she can set a theme according to their preferences in the dark/light mode . for example, I don't want to add any theme (just plain repo card) in light mode but whenever I switch to the dark mode I want the theme to changes to "material-palenight" (theme name)
Idea by screenshots
In light mode of GitHub
but when I switch mode to dark I need it to be like this
The text was updated successfully, but these errors were encountered: