fix: total commits count

[anuraghazra]

So as i mentioned in #14 that github api only return commits of 1 year max. what i did is that fetched all user years and then looped through that and made a graphql request for each year

    data: {
          query: `
          query userInfo($login: String!, $from: DateTime!, $to: DateTime!) {
            user(login: $login) {
              contributionsCollection(from: $from, to: $to) {
                totalCommitContributions
              }
            }
          }
        `,
          variables: {
            login: username,
            from: currentDate.toISOString(), // current year
            to: nextDate.toISOString(), // next year
          },
        },

TODO: perf improvement?

[anshumanv]

Looks good otherwise 💯

[anuraghazra]

@anshumanv Hi, i just did some performance testing and found out that to fetch all of your profile's commits it took over ~4 seconds to get back the response..

So do you have any ideas of improving the speed?

One thing i can do is have a option for specifying if users want to fetch all of the commits like ?fetch_all_commits=true

[anshumanv]

One thing i can do is have a option for specifying if users want to fetch all of the commits like ?fetch_all_commits=true

This is definitely one but I'm not sure of cases when a user would want to limit their count, but can't think of anything else atm. This seems the best choice to me. 👍

[anshumanv]

You can give it a count param too, for the number of queries i.e no of years.

[kingthorin]

Why not change the default text to "Current Year Commits" or "Commits for Last 365d" or something. With an option for "Total" commits along with a statement that there's a performance concern in doing such....

[TheAshwanik]

is this fixed and merged to master branch?

[anuraghazra]

No @TheAshwanik meanwhile you can hide the totalCommits stats if you want with hide=["commits"]

[anuraghazra]

Don't worry about rank it's not something that shows how skilled or how good you are. its just a rank for github activity. just like contribution chart. also fix would come up in this week, we need to fix the rank algo too because its biased currently

[TheAshwanik]

Don't worry about rank it's not something that shows how skilled or how good you are. its just a rank for github activity. just like contribution chart. also fix would come up in this week, we need to fix the rank algo too because its biased currently

Yes. Absolutely.
Thanks for your brilliant work.

[anuraghazra]

Fixed in #211