Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fetch all repos for top languages #2111

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

MatteoPierro
Copy link
Contributor

This fixed #1177

@vercel
Copy link

vercel bot commented Oct 4, 2022

@MatteoPierro is attempting to deploy a commit to the github readme stats Team on Vercel.

A member of the Team first needs to authorize it.

@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Base: 97.32% // Head: 97.33% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (a4b2347) compared to base (af97e57).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head a4b2347 differs from pull request most recent head 3741157. Consider uploading reports for the commit 3741157 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2111   +/-   ##
=======================================
  Coverage   97.32%   97.33%           
=======================================
  Files          22       22           
  Lines        3592     3603   +11     
  Branches      322      322           
=======================================
+ Hits         3496     3507   +11     
  Misses         95       95           
  Partials        1        1           
Impacted Files Coverage Δ
src/fetchers/top-languages-fetcher.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MatteoPierro
Copy link
Contributor Author

Could you review it? @rickstaa 🙏

tests/top-langs.test.js Show resolved Hide resolved
@tc-imba
Copy link

tc-imba commented Oct 9, 2022

LGTM

@rickstaa
Copy link
Collaborator

rickstaa commented Oct 9, 2022

@MatteoPierro Thanks for your pull request! I accepted your PR and added the hacktoberfest-accepted label. The contribution should appear in your Hacktoberfest dashboard and be accepted in 7 days. 🎉 I will, however, not merge it now due to the PATs rate limit problems we are experiencing (see #1471 (comment)). Including multiple pages would deplete the PATs even faster. We might merge it later by adding an environment variable that can be used to disable this feature on the public instance (see #2159). For this, we, however, have to run several tests to ensure that the maxDuration limit of Vercel is not being hit (see https://vercel.com/blog/customizing-serverless-functions).

@mirsella
Copy link

mirsella commented Mar 5, 2024

adding an environment variable that can be used to disable this feature

hello ! imo this is the best solution, or an opt-in approach where it's 100 by default, and we can increment the count on our self-hosted instances.
For some cases, this is the only use case for self-hosting it, and would be useful.

thanks !

@tc-imba
Copy link

tc-imba commented May 15, 2024

@rickstaa

I noticed that #2159 is merged with the new env var FETCH_MULTI_PAGE_STARS. This pull request only adds multi-page query of the stats card, but similar changes to the lang card are still not applied now.

I'm not sure whether you have tested the maxDuration limitation of personal deployed vercel, but considering the PR is merged I think it's ok. Is it possible to port FETCH_MULTI_PAGE_STARS to the lang card as well? Or we can use a more generalized env such as FETCH_MULTI_PAGE instead. I can write a new PR for this later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The most used languages only count the oldest 100 projects
4 participants