Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing term in calculation of TOTAL_VALUES. #2116

Merged
merged 5 commits into from
Nov 18, 2022
Merged

Missing term in calculation of TOTAL_VALUES. #2116

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7611fe5
fix: added missing term in calculation of TOTAL_VALUES.
fjosw Oct 4, 2022
e75c85b
fix: fix rank test
rickstaa Nov 18, 2022
da58b0f
refactor: update code formatting
rickstaa Nov 18, 2022
476b938
refactor: update code formatting
rickstaa Nov 18, 2022
ce68890
Merge branch 'fix/total_values-test' into fix/TOTAL_VALUES
rickstaa Nov 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/calculateRank.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ function calculateRank({
const RANK_B_VALUE = 100;

const TOTAL_VALUES =
RANK_S_VALUE + RANK_A2_VALUE + RANK_A3_VALUE + RANK_B_VALUE;
RANK_S_VALUE + RANK_DOUBLE_A_VALUE + RANK_A2_VALUE + RANK_A3_VALUE + RANK_B_VALUE;
rickstaa marked this conversation as resolved.
Show resolved Hide resolved

// prettier-ignore
const score = (
Expand Down