-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add 'progress' rank icon #2858
Conversation
This pull request allows users to replace the rank level with the rank progress by setting the `rank_icon` query to `progress`.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
f2874e1
to
3a9ae22
Compare
@qwerty541, I'm curious to know what you think about the text size and whether a space should be put between the number and the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@qwerty541, I'm curious to know what you think about the text size and whether a space should be put between the number and the
%
sign thinking?
I think that it looks nice right now.
https://github.com/silverwind updated, thanks. |
A bit too late for this PR but there is still a major UX issue. If I were to visit someone's profile and it just says 80% how would they know what that even means? Maybe one could add something like "Top" above the percentage to for example indicate that they perform better than 80% in some way. (If that is what that means, I'm just guessing) |
Good point. Progress is how far along a user is compared to the highest possible score. It is the inverse of the percentage explained in the documentation:
We can change it to equal the ![Anurag's GitHub stats](https://github-readme-stats-git-addprogressrankicon-rickstaa.vercel.app/api?username=silverwind&rank_icon=progress) |
@qwerty541 do you agree that |
I personally think the top percentage (for example top 0.9% instead of 99.1%) is better as it carries more meaning. You cant compare yourself against numbers without units/meaning or with too complicated units/meaning. A top percentage is an easy and intuitive metric. |
Does #2859 suit your need? [![Anurag's GitHub stats](https://github-readme-stats-git-addpercentilerankicon-rickstaa.vercel.app//api?username=mindlabordev&rank_icon=percentile)](https://github.com/anuraghazra/github-readme-stats) |
Yes, this seems better UX-wise. UI-wise you could make "Top" the same size as other text like "total stars earned" but that's just me being picky. 👍 |
Nice tip. I updated the styling. If you have any other improvements, let me know. [![Anurag's GitHub stats](https://github-readme-stats-git-addpercentilerankicon-rickstaa.vercel.app/api?username=mindlabordev&rank_icon=percentile)](https://github.com/anuraghazra/github-readme-stats) |
Hard to see the difference but |
yea hard to tell but this is absolutely fine. |
Cool thanks for the amazing feedback. I will ask @qwerty541 to review and merge your feature request. |
@silverwind do you prefer the |
@silverwind, we decided to replace |
This pull request allows users to replace the rank level with the rank progress by setting the `rank_icon` query to `progress`.
This pull request allows users to replace the rank level with the rank progress by setting the `rank_icon` query to `progress`.
This pull request allows users to replace the rank level with the rank progress by setting the `rank_icon` query to `progress`.
This pull request allows users to replace the rank level with the rank progress by setting the
rank_icon
query toprogress
.Preview