-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed resizing of stats card when all metrics except rank are hidden #2868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@iwbc-mzk is attempting to deploy a commit to the github readme stats Team on Vercel. A member of the Team first needs to authorize it. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2868 +/- ##
==========================================
- Coverage 97.72% 97.61% -0.11%
==========================================
Files 24 24
Lines 5094 5153 +59
Branches 452 460 +8
==========================================
+ Hits 4978 5030 +52
- Misses 115 122 +7
Partials 1 1
☔ View full report in Codecov by Sentry. |
rickstaa
approved these changes
Jun 22, 2023
Thanks for this fix! 🚀 |
HackingGate
pushed a commit
to HackingGate/github-readme-stats
that referenced
this pull request
Jun 25, 2023
…nuraghazra#2868) * fixed card resizing in case of rank only * fixed to display error when both stats and rank are hidden * fix: fix visual alignment --------- Co-authored-by: rickstaa <rick.staa@outlook.com>
J00MZ
pushed a commit
to J00MZ/github-readme-stats
that referenced
this pull request
Jul 23, 2023
…nuraghazra#2868) * fixed card resizing in case of rank only * fixed to display error when both stats and rank are hidden * fix: fix visual alignment --------- Co-authored-by: rickstaa <rick.staa@outlook.com>
devantler
pushed a commit
to devantler/github-readme-stats
that referenced
this pull request
Sep 24, 2023
…nuraghazra#2868) * fixed card resizing in case of rank only * fixed to display error when both stats and rank are hidden * fix: fix visual alignment --------- Co-authored-by: rickstaa <rick.staa@outlook.com>
setdebarr
pushed a commit
to setdebarr/github-readme-stats
that referenced
this pull request
Jan 12, 2024
…nuraghazra#2868) * fixed card resizing in case of rank only * fixed to display error when both stats and rank are hidden * fix: fix visual alignment --------- Co-authored-by: rickstaa <rick.staa@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
card-i18n
Card text translations.
stats-card
Feature, Enhancement, Fixes related to stats the stats card.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed resizing of stats card when all metrics except rank are hidden.
The title is fixed from "stats" to "rank" only for en/ja locale. The Others remain unchanged from "statcard.title".
I am not good at English so the error text may be wrong. Please let me know if you have a suggestion for a fix.
fixed card
![Anurag's GitHub stats](https://camo.githubusercontent.com/c94fb85b73c0739304ae63a6566b00e3a7737e59c1b6b1b40c46abb468eaa1a6/68747470733a2f2f6769746875622d726561646d652d73746174732d6769742d72616e6b2d6f6e6c792d73746174732d636172642d697762632d6d7a6b2e76657263656c2e6170702f6170693f757365726e616d653d616e7572616768617a726126686964653d636f6e74726962732c7072732c73746172732c636f6d6d6974732c697373756573)
error
![Anurag's GitHub stats](https://camo.githubusercontent.com/828320fc0399b3ebcc3338b5b3ac049f94db6ade5b751cc57217458254e156ed/68747470733a2f2f6769746875622d726561646d652d73746174732d6769742d72616e6b2d6f6e6c792d73746174732d636172642d697762632d6d7a6b2e76657263656c2e6170702f6170693f757365726e616d653d616e7572616768617a726126686964653d636f6e74726962732c7072732c73746172732c636f6d6d6974732c69737375657326686964655f72616e6b3d74727565)
all test passed.
![image](https://private-user-images.githubusercontent.com/46069337/247530292-1b6c5808-b95f-44c9-948f-551d844a42fc.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk5ODY1MTQsIm5iZiI6MTcxOTk4NjIxNCwicGF0aCI6Ii80NjA2OTMzNy8yNDc1MzAyOTItMWI2YzU4MDgtYjk1Zi00NGM5LTk0OGYtNTUxZDg0NGE0MmZjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzAzVDA1NTY1NFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTA3MmEyMmIwZjNiYjM0ZTllMmE2Mjc0MDE4MjI5YTAyZGQ4YmM2YjZkYThiOWQ0OWY0OTU3NDNhZDRlNDUzZGQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.dogDdDR74Zf_fxddv6xf2iWXzheiV_KAow1Y5qtSkAE)
issue: #1649