Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed resizing of stats card when all metrics except rank are hidden #2868

Merged
merged 3 commits into from
Jun 22, 2023

Conversation

iwbc-mzk
Copy link
Contributor

Fixed resizing of stats card when all metrics except rank are hidden.
The title is fixed from "stats" to "rank" only for en/ja locale. The Others remain unchanged from "statcard.title".
I am not good at English so the error text may be wrong. Please let me know if you have a suggestion for a fix.

fixed card
Anurag's GitHub stats

error
Anurag's GitHub stats

all test passed.
image

issue: #1649

@vercel
Copy link

vercel bot commented Jun 21, 2023

@iwbc-mzk is attempting to deploy a commit to the github readme stats Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added card-i18n Card text translations. stats-card Feature, Enhancement, Fixes related to stats the stats card. labels Jun 21, 2023
@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Patch coverage: 91.42% and project coverage change: -0.11 ⚠️

Comparison is base (2642fc5) 97.72% compared to head (7f422f5) 97.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2868      +/-   ##
==========================================
- Coverage   97.72%   97.61%   -0.11%     
==========================================
  Files          24       24              
  Lines        5094     5153      +59     
  Branches      452      460       +8     
==========================================
+ Hits         4978     5030      +52     
- Misses        115      122       +7     
  Partials        1        1              
Impacted Files Coverage Δ
src/cards/stats-card.js 98.22% <84.61%> (-1.78%) ⬇️
src/translations.js 99.84% <100.00%> (+<0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rickstaa rickstaa merged commit a48d653 into anuraghazra:master Jun 22, 2023
3 of 4 checks passed
@rickstaa
Copy link
Collaborator

Thanks for this fix! 🚀

@iwbc-mzk iwbc-mzk deleted the rank-only-stats-card branch June 24, 2023 07:59
HackingGate pushed a commit to HackingGate/github-readme-stats that referenced this pull request Jun 25, 2023
…nuraghazra#2868)

* fixed card resizing in case of rank only

* fixed to display error when both stats and rank are hidden

* fix: fix visual alignment

---------

Co-authored-by: rickstaa <rick.staa@outlook.com>
J00MZ pushed a commit to J00MZ/github-readme-stats that referenced this pull request Jul 23, 2023
…nuraghazra#2868)

* fixed card resizing in case of rank only

* fixed to display error when both stats and rank are hidden

* fix: fix visual alignment

---------

Co-authored-by: rickstaa <rick.staa@outlook.com>
devantler pushed a commit to devantler/github-readme-stats that referenced this pull request Sep 24, 2023
…nuraghazra#2868)

* fixed card resizing in case of rank only

* fixed to display error when both stats and rank are hidden

* fix: fix visual alignment

---------

Co-authored-by: rickstaa <rick.staa@outlook.com>
setdebarr pushed a commit to setdebarr/github-readme-stats that referenced this pull request Jan 12, 2024
…nuraghazra#2868)

* fixed card resizing in case of rank only

* fixed to display error when both stats and rank are hidden

* fix: fix visual alignment

---------

Co-authored-by: rickstaa <rick.staa@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
card-i18n Card text translations. stats-card Feature, Enhancement, Fixes related to stats the stats card.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants