Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.js #2877

Closed
wants to merge 4 commits into from
Closed

Update index.js #2877

wants to merge 4 commits into from

Conversation

sims1710
Copy link

I created a theme which focuses on pastel pink, hope you find okay and can add it to your themes!

@vercel
Copy link

vercel bot commented Jun 22, 2023

@sims1710 is attempting to deploy a commit to the github readme stats Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the themes Feature, Enhancement, Fixes related to themes. label Jun 22, 2023
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something went wrong in the theme preview action: PR diff is not a valid theme JSON object.

@github-actions github-actions bot added the invalid The bug/issue caused by minor mistakes. label Jun 22, 2023
themes/index.js Outdated Show resolved Hide resolved
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something went wrong in the theme preview action: PR diff is not a valid theme JSON object.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 24, 2023

Automated Theme Preview

Hi, thanks for the theme contribution. Please read our theme contribution guidelines.

Warning

Keep in mind that we already have a vast collection of different themes. To keep their number manageable, we began to add only themes supported by the community. Your pull request with theme addition will be merged once we get enough positive feedback from the community in the form of thumbs up (see #1935). Remember that you can also support themes of other contributors that you liked to speed up their merge.

Note

Also, note that if this theme is exclusively for your personal use, then instead of adding it to our theme collection, you can use card customization options.

✔️ Theme PR does adhere to our guidelines.

Test results

  • ✔️ pastel_pink

Result: ✔️ All themes are valid.

Details

Pastel_pink theme preview

title_color: #DF2A5A | icon_color: #EB001B | text_color: #757575 | bg_color: #fffefe | border_color: #e4e2e2

Preview Link

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some themes are invalid. See the Automated Theme Preview comment above for more information.

@codecov
Copy link

codecov bot commented Jun 24, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (a48d653) 97.61% compared to head (5e430e2) 97.61%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2877   +/-   ##
=======================================
  Coverage   97.61%   97.61%           
=======================================
  Files          24       24           
  Lines        5153     5163   +10     
  Branches      460      460           
=======================================
+ Hits         5030     5040   +10     
  Misses        122      122           
  Partials        1        1           
Impacted Files Coverage Δ
themes/index.js 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions github-actions bot removed the invalid The bug/issue caused by minor mistakes. label Jun 30, 2023
Copy link
Collaborator

@qwerty541 qwerty541 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sims1710 I have resolved JSON syntax and contrast check errors on your pull request. Now it will no be automatically closed, but card looks a little different. Feel free to revert changes.

@github-actions github-actions bot added ⭐ top pull request Top pull request. ⭐ top themes Top themes labels Jul 1, 2023
@github-actions github-actions bot mentioned this pull request Jul 1, 2023
@github-actions github-actions bot removed the ⭐ top pull request Top pull request. label Jul 7, 2023
@github-actions github-actions bot added the ⭐ top pull request Top pull request. label Aug 22, 2023
@anuraghazra
Copy link
Owner

We are currently pausing addition of new themes. If this theme is exclusively for your personal use, then instead of adding it to our theme collection, you can use card customization options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭐ top pull request Top pull request. ⭐ top themes Top themes themes Feature, Enhancement, Fixes related to themes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants