Eslint integration #2885
Merged
Eslint integration #2885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
dependencies
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2885 +/- ##
=======================================
Coverage 97.61% 97.61%
=======================================
Files 24 24
Lines 5156 5159 +3
Branches 460 460
=======================================
+ Hits 5033 5036 +3
Misses 122 122
Partials 1 1
☔ View full report in Codecov by Sentry. |
Closed
qwerty541
commented
Jun 27, 2023
There was a problem hiding this comment.
@rickstaa This is basic integration of eslint. As you see most of rules inside eslintrc.json under comments, enabled only object-shorthand and default. We can gradually uncomment rules and improve code quality. I also added checking lints on continuous integration and pre commit hook.
rickstaa
reviewed
Jun 30, 2023
rickstaa
reviewed
Jun 30, 2023
rickstaa
requested changes
Jun 30, 2023
anuraghazra
approved these changes
Jul 1, 2023
rickstaa
approved these changes
Jul 3, 2023
J00MZ
pushed a commit
to J00MZ/github-readme-stats
that referenced
this pull request
Jul 23, 2023
* eslint integration * ci & pre commit * dev * dev * dev
devantler
pushed a commit
to devantler/github-readme-stats
that referenced
this pull request
Sep 24, 2023
* eslint integration * ci & pre commit * dev * dev * dev
setdebarr
pushed a commit
to setdebarr/github-readme-stats
that referenced
this pull request
Jan 12, 2024
* eslint integration * ci & pre commit * dev * dev * dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2882 (comment)