Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Fix pull requests labeler workflow error #2905

Closed
wants to merge 1 commit into from

Conversation

qwerty541
Copy link
Collaborator

@qwerty541 qwerty541 commented Jul 2, 2023

@qwerty541 qwerty541 requested a review from rickstaa July 2, 2023 21:13
@vercel
Copy link

vercel bot commented Jul 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
github-readme-stats ✅ Ready (Inspect) Visit Preview Jul 2, 2023 9:13pm

@codecov
Copy link

codecov bot commented Jul 2, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (de4efa9) 97.61% compared to head (71b8d29) 97.61%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2905   +/-   ##
=======================================
  Coverage   97.61%   97.61%           
=======================================
  Files          24       24           
  Lines        5156     5156           
  Branches      460      460           
=======================================
  Hits         5033     5033           
  Misses        122      122           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions github-actions bot added the ci CI related features. label Jul 2, 2023
@rickstaa
Copy link
Collaborator

rickstaa commented Jul 3, 2023

@qwerty541 This bug should not exist according to the documentation. I tried it with other triggers, and it does not show up (see https://github.com/rickstaa/issues-permission-error/actions/workflows/issues-permission-test-read.yml). Maybe it happens when the pull_request_target trigger is used. Would it be possible for you to create a PR on https://github.com/rickstaa/issues-permission-error so we can test this behaviour and file a bug report with @github?

Copy link
Collaborator Author

@qwerty541 qwerty541 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qwerty541 This bug should not exist according to the documentation. I tried it with other triggers, and it does not show up (see https://github.com/rickstaa/issues-permission-error/actions/workflows/issues-permission-test-read.yml). Maybe it happens when the pull_request_target trigger is used. Would it be possible for you to create a PR on https://github.com/rickstaa/issues-permission-error so we can test this behaviour and file a bug report with @github?

I have opened pull request rickstaa/issues-permission-error#1 and all checks passed. But i noticed that there are no actions/labeler inside your repository. As you see this error happens only with one of our workflows which contains pull requests labeler. I think that error can be connected to some actions/labeler requirements, but their documentation tells that it needs only contents: read and pull-requests: write permissions. Very strange.

@qwerty541
Copy link
Collaborator Author

Looks like there are no more such errors happens with this workflow: https://github.com/anuraghazra/github-readme-stats/actions/workflows/label-pr.yml.

This pull request is no actual for now.

@rickstaa
Copy link
Collaborator

@qwerty541 strange 🤔. Maybe we can close it for now?

@rickstaa rickstaa closed this Jul 11, 2023
@qwerty541
Copy link
Collaborator Author

@qwerty541 strange thinking. Maybe we can close it for now?

@rickstaa Yes, for now it should be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci CI related features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants