fix: firefox layout breaking

[anuraghazra]

fixes #45

[anuraghazra]

@saurabhdaware can you check the updates?

here's live development preview (without icons)

with icons

without fix:

[cjdenio]

It's definitely better, but still a bit off.

[anuraghazra]

@cjdenio Yes i checked it, i have no idea why tho, its working fine locally. ff has lot of issues with SVGs 😩 weird

[cjdenio]

Weird, it works perfectly when icons are turned on.

[anuraghazra]

Huh! very weird

[anuraghazra]

Oh got it, for some reason user-agent isn't recognized

[saurabhdaware]

Yes I have same output as @cjdenio

[anuraghazra]

Ahh got it, the problem is that in the request headers i'm getting github-camo instead of firefox's ua which makes sense because the API is hit from server not directly from browser, any ideas to fix this? @saurabhdaware @cjdenio

[saurabhdaware]

Can we fix that on frontend? https://stackoverflow.com/questions/5378559/including-javascript-in-svg

Edit:
So after getting response it will send javascript along with it that will fix that space on frontend

P.S. Super noob with SVGs so I have no idea if this makes sense or not

[anuraghazra]

Not that easy i assume, the SVGs wont gonna be rendered as SVG or pure HTML elements by github, github will automatically upload the svg to their camo.githubusercontent cdn and then render that as image.

[saurabhdaware]

ahh yes right

[anuraghazra]

@saurabhdaware can you check again it should be fixed :D

[cjdenio]

Looks perfect!

[anuraghazra]

Awesome! thanks @cjdenio

[saurabhdaware]

uh oh I turned off my laptop and sleeping now :( so probably by tomorrow morning

[anuraghazra]

No issues @saurabhdaware @cjdenio sent the screenshot its working fine now, thanks for helping out, and reporting the bug. ❤️