New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated translations.js to include Portuguese (Portugal) translations. #570
Conversation
Updated translations.js to include Portuguese (Portugal) translations.
Codecov Report
@@ Coverage Diff @@
## master #570 +/- ##
=======================================
Coverage 91.64% 91.64%
=======================================
Files 22 22
Lines 634 634
Branches 174 174
=======================================
Hits 581 581
Misses 47 47
Partials 6 6
Continue to review full report at Codecov.
|
Hi @joseborges thanks for the contribution. Although we already have the pt-br 🤔 do we really need the pt-pt? i have no idea. |
Hi, I get this question all the time, and I always explain the same, that Portuguese (from Portugal) is not the same as Portuguese (from Brasil), there are several differences, many more than between "American" english and "British" english. I understand you don't see it this way, since it's a foreigner language to you, but I'm not Brazilian, I'm Portuguese, so my native language is Portuguese and not Brazilian. That being said, this is a recurring issue, and I accept if you don't merge this PR on your project for, in your opinion, they are the same, but that won't change the fact they are trully diferent. Kind regards. (PS: If I sounded agressive, it's not my intention, i was just trying to be explicit about the issue) |
Hi, could you please add this PR so that it counts to the #hacktoberfest 2020? It's a legit PR... Thanks! |
@joseborges ahh I see. Yup got it. Yeah in our native language we also have different version of same language. I'll accept the PR then. Thanks! |
…aghazra#570) Updated translations.js to include Portuguese (Portugal) translations.
…aghazra#570) Updated translations.js to include Portuguese (Portugal) translations.
…aghazra#570) Updated translations.js to include Portuguese (Portugal) translations.
Updated translations.js to include Portuguese (Portugal) translations.