Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated translations.js to include Portuguese (Portugal) translations. #570

Merged
merged 1 commit into from Oct 25, 2020
Merged

Conversation

joseborges
Copy link
Contributor

Updated translations.js to include Portuguese (Portugal) translations.

Updated translations.js to include Portuguese (Portugal) translations.
@codecov
Copy link

codecov bot commented Oct 13, 2020

Codecov Report

Merging #570 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #570   +/-   ##
=======================================
  Coverage   91.64%   91.64%           
=======================================
  Files          22       22           
  Lines         634      634           
  Branches      174      174           
=======================================
  Hits          581      581           
  Misses         47       47           
  Partials        6        6           
Impacted Files Coverage Δ
src/translations.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b1e019...3b9f35e. Read the comment docs.

@anuraghazra
Copy link
Owner

Hi @joseborges thanks for the contribution.

Although we already have the pt-br 🤔 do we really need the pt-pt? i have no idea.

@joseborges
Copy link
Contributor Author

joseborges commented Oct 17, 2020

Hi, I get this question all the time, and I always explain the same, that Portuguese (from Portugal) is not the same as Portuguese (from Brasil), there are several differences, many more than between "American" english and "British" english.

I understand you don't see it this way, since it's a foreigner language to you, but I'm not Brazilian, I'm Portuguese, so my native language is Portuguese and not Brazilian.

That being said, this is a recurring issue, and I accept if you don't merge this PR on your project for, in your opinion, they are the same, but that won't change the fact they are trully diferent.

Kind regards.

(PS: If I sounded agressive, it's not my intention, i was just trying to be explicit about the issue)

@joseborges
Copy link
Contributor Author

Hi, could you please add this PR so that it counts to the #hacktoberfest 2020? It's a legit PR... Thanks!

@anuraghazra
Copy link
Owner

@joseborges ahh I see.

Yup got it. Yeah in our native language we also have different version of same language.

I'll accept the PR then. Thanks!

@anuraghazra anuraghazra merged commit 805f1c4 into anuraghazra:master Oct 25, 2020
infinity-plus pushed a commit to infinity-plus/github-readme-stats that referenced this pull request Oct 29, 2020
…aghazra#570)

Updated translations.js to include Portuguese (Portugal) translations.
NightScript370 pushed a commit to NightScript370/github-readme-stats that referenced this pull request Dec 8, 2020
…aghazra#570)

Updated translations.js to include Portuguese (Portugal) translations.
Kab1r pushed a commit to Kab1r/github-readme-stats that referenced this pull request Apr 4, 2022
…aghazra#570)

Updated translations.js to include Portuguese (Portugal) translations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants