Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add union. #115

Merged
merged 2 commits into from Aug 13, 2020
Merged

Add union. #115

merged 2 commits into from Aug 13, 2020

Conversation

ghost
Copy link

@ghost ghost commented Aug 11, 2020

Hey!

This would be a useful function for us.

@anuragsoni
Copy link
Owner

anuragsoni commented Aug 12, 2020 •
edited

Hi @Chattered,

Thank you for your contribution! Adding an option to create a union of two routers is indeed very useful. Would you mind adding some tests for this?

@anuragsoni
Copy link
Owner

The tests live under https://github.com/anuragsoni/routes/blob/c3b5e4f00d1c3bf0e6663421c186f65d14ccda61/test/routing_test.ml

@anuragsoni anuragsoni merged commit a8a56f7 into anuragsoni:master Aug 13, 2020
@anuragsoni
Copy link
Owner

Thank you!

@ghost
Copy link
Author

ghost commented Aug 13, 2020

Great stuff! Thanks for accepting the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@anuragsoni