Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kev/3_popup_login_integration #51

Merged
merged 17 commits into from
Mar 19, 2024
Merged

Kev/3_popup_login_integration #51

merged 17 commits into from
Mar 19, 2024

Conversation

junhaow1
Copy link
Collaborator

@junhaow1 junhaow1 commented Mar 4, 2024

Pull Request Details

What issue does this PR address

  • [A one line description of this PR]

  • Link to associated issue: #

Checklist

[Use the check-list below to ensure your branch is ready for PR]

  • Changes adhere to the team style and coding guideline
  • The one line summary included in CHANGELOG.md
  • No confidential information
  • No duplicated content
  • No lint errors (make prep or flutter analyze lib
    python: use pre-commit ruff hook to check on commit)
  • No lint check errors related to your changes
  • Tested on at least one device
    - [ ] Android
    - [ ] Chrome
    - [ ] iOS
    - [ ] Linux
    - [ ] MacOS
    - [ ] Windows
  • Added 2 reviewers

Flutter Style Guide: https://survivor.togaware.com/gnulinux/flutter-style.html

Finalising

Once PR discussion is complete and 2 reviewers have approved:

  • Merge dev into the branch
  • Resolve any conflicts
  • Bump appropriate version number
  • Merge PR into dev

@junhaow1
Copy link
Collaborator Author

This is ready to be merged as well @anushkavidanage :)

@anushkavidanage
Copy link
Collaborator

@junhaow1 some checks for this PR are failing. Could you please have a look and fix those ASAP?

@junhaow1
Copy link
Collaborator Author

@junhaow1 some checks for this PR are failing. Could you please have a look and fix those ASAP?

doing now

Copy link

LCOV of commit 048bdd3 during Code Coverage Check #109

Summary coverage rate:
  lines......: 100.0% (5 of 5 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

Copy link
Collaborator

@cdawei cdawei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked in my test.

@junhaow1 junhaow1 merged commit 6dd3300 into dev Mar 19, 2024
1 check passed
@junhaow1 junhaow1 deleted the kev/3_popup_login branch March 19, 2024 23:00
Copy link

LCOV of commit 18c55c2 during Code Coverage Check #113

Summary coverage rate:
  lines......: 100.0% (5 of 5 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants