-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kev/3_popup_login_integration #51
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
This is ready to be merged as well @anushkavidanage :) |
@junhaow1 some checks for this PR are failing. Could you please have a look and fix those ASAP? |
doing now |
anushkavidanage
approved these changes
Mar 19, 2024
LCOV of commit
|
cdawei
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked in my test.
LCOV of commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Details
What issue does this PR address
[A one line description of this PR]
Link to associated issue: #
Checklist
[Use the check-list below to ensure your branch is ready for PR]
make prep
orflutter analyze lib
python: use pre-commit ruff hook to check on commit)
- [ ] Android
- [ ] Chrome
- [ ] iOS
- [ ] Linux
- [ ] MacOS
- [ ] Windows
Flutter Style Guide: https://survivor.togaware.com/gnulinux/flutter-style.html
Finalising
Once PR discussion is complete and 2 reviewers have approved: