Skip to content

Changed Browser.ie to Browser.ie6 #102

Merged
merged 1 commit into from May 9, 2014

2 participants

@RiZKiT
RiZKiT commented Jun 5, 2012

No description provided.

@anutron
Owner
anutron commented Jun 5, 2012

did you test this in other versions of IE?

@RiZKiT
RiZKiT commented Jun 6, 2012
  1. there is a comment at the end of the line which says IE6 bullshit, so i expected it is for IE6 only
  2. in an old version of clientcide the check was for Browser.engine.trident4

I wanted to test it with ur examples but:

@anutron
Owner
anutron commented Jun 8, 2012

re: #2, that means that at some point I broadened the definition to include any version of IE for some reason.

I need to audit all those links... here's the current one:

http://dev.clientcide.com/Clientcide%203.0.12/demo/?project=Clientcide&path=/UI/StickyWin.UI.Pointy.html

You can run this development environment locally (which makes it easy to run both the automated tests but also the interactive ones) by doing this:

$ git clone git://github.com/anutron/mootools-development.git
$ cd mootools-development
$ ./install
$ ./go r
// then open localhost:9876

Installation takes a 3 or 4 minutes. Once done, you'll have a copy of clientcide and all it's dependencies in lib/clientcide

@RiZKiT
RiZKiT commented Jun 12, 2012

I've tested it now in IE7-9 with your online version and removing the style.
The specific line about font-size isn't needed for these versions. So you could pull this change.

@anutron anutron merged commit c65d79a into anutron:master May 9, 2014
@RiZKiT RiZKiT deleted the RiZKiT:patch-6 branch May 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.