Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Changed Browser.ie to Browser.ie6 #102

Merged
merged 1 commit into from

2 participants

@RiZKiT

No description provided.

@anutron
Owner

did you test this in other versions of IE?

@RiZKiT
  1. there is a comment at the end of the line which says IE6 bullshit, so i expected it is for IE6 only
  2. in an old version of clientcide the check was for Browser.engine.trident4

I wanted to test it with ur examples but:

@anutron
Owner

re: #2, that means that at some point I broadened the definition to include any version of IE for some reason.

I need to audit all those links... here's the current one:

http://dev.clientcide.com/Clientcide%203.0.12/demo/?project=Clientcide&path=/UI/StickyWin.UI.Pointy.html

You can run this development environment locally (which makes it easy to run both the automated tests but also the interactive ones) by doing this:

$ git clone git://github.com/anutron/mootools-development.git
$ cd mootools-development
$ ./install
$ ./go r
// then open localhost:9876

Installation takes a 3 or 4 minutes. Once done, you'll have a copy of clientcide and all it's dependencies in lib/clientcide

@RiZKiT

I've tested it now in IE7-9 with your online version and removing the style.
The specific line about font-size isn't needed for these versions. So you could pull this change.

@anutron anutron merged commit c65d79a into from
@RiZKiT RiZKiT deleted the branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jun 5, 2012
  1. Changed Browser.ie to Browser.ie6

    Aicke Schulz authored
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  Source/UI/StickyWin.UI.Pointy.js
View
2  Source/UI/StickyWin.UI.Pointy.js
@@ -213,7 +213,7 @@ StickyWin.UI.Pointy = new Class({
setContent: function(a1, a2){
this.parent(a1, a2);
this.top[this.h1?'removeClass':'addClass']('noCaption');
- if (Browser.ie) document.id(this).getElements('.bottom_ll, .bottom_lr').setStyle('font-size', 1); //IE6 bullshit
+ if (Browser.ie6) document.id(this).getElements('.bottom_ll, .bottom_lr').setStyle('font-size', 1); //IE6 bullshit
if (this.options.closeButton) this.body.setStyle('margin-right', 6);
this.positionPointer();
return this;
Something went wrong with that request. Please try again.