Skip to content
This repository has been archived by the owner on Feb 25, 2019. It is now read-only.

Will you accept a PR updating the Dependencies? #300

Closed
nelsonic opened this issue Dec 15, 2015 · 5 comments
Closed

Will you accept a PR updating the Dependencies? #300

nelsonic opened this issue Dec 15, 2015 · 5 comments

Comments

@nelsonic
Copy link
Contributor

At present a few dependencies are out of date: Dependency Status can we submit a PR updating them?

@christiansmith
Copy link
Member

Just took a look using david.

$ david
dependencies

┌───────────────────┬─────────────────────┬────────┐
│ Name              │ Package             │ Latest │
├───────────────────┼─────────────────────┼────────┤
│ ldapjs            │ mcavage/node-ldapjs │ 1.0.0  │
├───────────────────┼─────────────────────┼────────┤
│ qs                │ ^5.0.0              │ 6.0.1  │
├───────────────────┼─────────────────────┼────────┤
│ passport-saml     │ ^0.13.0             │ 0.14.0 │
├───────────────────┼─────────────────────┼────────┤
│ passport-ldapauth │ ^0.3.0              │ 0.5.0  │
└───────────────────┴─────────────────────┴────────┘

npm install --save ldapjs@1.0.0 qs@6.0.1 passport-saml@0.14.0 passport-ldapauth@0.5.0

devDependencies

┌──────┬─────────┬────────┐
│ Name │ Package │ Latest │
├──────┼─────────┼────────┤
│ nock │ ^2.2.0  │ 3.4.1  │
└──────┴─────────┴────────┘

npm install --save-dev nock@3.4.1

I can accept an update to nock and qs, for sure.

The LDAP and SAML related packages require thorough testing against live instances with the new library versions and we don't really have time to go there before year end unless @vsimonian or someone else wants to jump back in and help to verify.

@nelsonic
Copy link
Contributor Author

@christiansmith should I update the version of the package to 0.1.59 in package.json ?

nelsonic added a commit to nelsonic/connect that referenced this issue Dec 15, 2015
@christiansmith
Copy link
Member

Please do not update the package version. We use grunt-release to automate releases, and this increments the version in package.json. We have other outstanding work to wrap up before doing another release.

@nelsonic
Copy link
Contributor Author

@christiansmith I have not updated the package version in the PR.
But did update the version of Node.js in .travis.yml as discussed in #302

@nelsonic
Copy link
Contributor Author

Closed by #301

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants