Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logout #28

Closed
wants to merge 1 commit into from
Closed

Conversation

rishabhcs53
Copy link
Contributor

No description provided.

@rishabhcs53 rishabhcs53 mentioned this pull request Jan 9, 2016

echo json_encode(array("status" => true, "msg" => "Successfully Log Out"));

session_destroy();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Control flow error !!!
session can't be started or destroyed after sending message to the browser - as they deal with headers.
Line 11 can't come after line 9.
It's pure logical error ( man your'e sending status true even before destroying session ??!!)
Resubmit the PR.

@rishabhcs53 rishabhcs53 closed this Jan 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants