Dev-2790 > Fixed retrying on transaction #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jettcalleja
changed the title
pandafox
requested changes
Jul 27, 2018
test/test.js
Outdated
| (err) => { | ||
| err.should.exist; | ||
| } | ||
| ) |
There was a problem hiding this comment.
Also test running with a valid query and follow by an invalid query?
test/test.js
Outdated
| ) | ||
| .commit(err => { | ||
| err.should.exist; | ||
| err.code.should.be.equal('ER_MAX_RETRIES') |
There was a problem hiding this comment.
Should also validate how many times the retry happens?
test/test.js
Outdated
| err.should.exist; | ||
| err.code.should.be.equal('ER_MAX_RETRIES') | ||
| done(); | ||
| }); |
There was a problem hiding this comment.
Should also test
- retry failed with max retry
- verify retry is reset for next query
- adjust retry and is able to fail with max retry again
pandafox
approved these changes
Jul 30, 2018
wildtron
approved these changes
Jul 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket references
Summary of changes
Checklist
Testing