-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev-2790 > Fixed retrying on transaction #21
Conversation
test/test.js
Outdated
(err) => { | ||
err.should.exist; | ||
} | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also test running with a valid query and follow by an invalid query?
test/test.js
Outdated
) | ||
.commit(err => { | ||
err.should.exist; | ||
err.code.should.be.equal('ER_MAX_RETRIES') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should also validate how many times the retry happens?
test/test.js
Outdated
err.should.exist; | ||
err.code.should.be.equal('ER_MAX_RETRIES') | ||
done(); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should also test
- retry failed with max retry
- verify retry is reset for next query
- adjust retry and is able to fail with max retry again
Ticket references
Summary of changes
Checklist
Testing