Feat/add test cable implementation #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palkan
requested changes
Oct 29, 2021
palkan
reviewed
Oct 29, 2021
TheSeally
force-pushed
the
feat/add_test_cable
branch
from
a413fac
to
dd04c46
Compare
|
Added README section for testing. Also added tests for check non existing identifier (checks that |
palkan
approved these changes
Nov 3, 2021
TheSeally
force-pushed
the
feat/add_test_cable
branch
from
dd04c46
to
6f469ea
Compare
Fixed problem in readme. Also added change log entry, but please see if I did it correctly |
|
Thanks for your help! Could you please tell me your name (so I can add to CultOfMartians)? |
|
Thanks for review. My name is Виктор Малий |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8
Added test cable implementation according to example from issue.
If this implementations fits I will also update Readme section in repo.