Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (subscribe): re-subscribe if already subscribed #142

Closed
wants to merge 1 commit into from

Conversation

bradrees
Copy link

Fixes the issue where the client goes into sleep and cannot reconnect without a full reload. Noticeable on iOS and Electron

Fixes #141

Fixes the issue where the client goes into sleep and cannot reconnect without a full reload. Noticeable on iOS and Electron
@palkan
Copy link
Member

palkan commented Nov 11, 2021

I'm not sure my attached PR fixes anything related to this issue, although it does prevent that 'Already subscribed' message from showing up.

Yeah, I don't think we fix the problem here; just hiding symptoms.
Sending subscribe commands when the connection's state already includes this subscription is a client-side misbehavior. We should dig this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client cannot reconnect after going to sleep
2 participants