Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There is no "precommit" npm script #101

Closed
3 tasks done
developomp opened this issue Jul 24, 2023 · 1 comment · Fixed by #105
Closed
3 tasks done

There is no "precommit" npm script #101

developomp opened this issue Jul 24, 2023 · 1 comment · Fixed by #105
Assignees
@fuksman
Labels
bug Something isn't working

Comments

@developomp
Copy link
Contributor

Have you read a contributing guide?

  • I have read CONTRIBUTING.md
  • I have searched the existing issues and didn't find any that were similar
  • I have considered creating a pull request with fixes instead of a bug report and want to proceed

Current Behavior

The following command will always fail and the second part of the command (git add licenses.json) will never run because there is no precommit npm script.

anytype-ts/package.json

Line 558 in 6d9dc0e

"pre-commit": "npm run precommit && git add licenses.json"

Expected Behavior

Either npm run precommit is removed or the script exists.

Steps To Reproduce

  1. Clone the repository
  2. Run npm run precommit
  3. See it failing

Environment

- OS: Arch Linux Rolling
- Version: 6d9dc0e4713b031fedbd9d5d8382f6db53817953

Anything else?

No response
@developomp developomp added the bug Something isn't working label Jul 24, 2023
@developomp
Copy link
Contributor Author

The missing script is probably lint-staged

@fuksman fuksman self-assigned this Jul 24, 2023
developomp added a commit to developomp/anytype-ts that referenced this issue Jul 24, 2023
@developomp
fix: closes anyproto#101
d12a78c
@developomp developomp mentioned this issue Jul 24, 2023
Merged
ra3orblade added a commit that referenced this issue Jul 24, 2023
@ra3orblade
Merge pull request #105 from developomp/close-101
5e66828 
fix: closes #101
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fuksman fuksman

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: closes #101 developomp/anytype-ts
2 participants
@fuksman @developomp