Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.17: Change DEFAULT_TPU_CONNECTION_POOL_SIZE to 1 (backport of #1014) #1042

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Apr 25, 2024

Problem

DEFAULT_TPU_CONNECTION_POOL_SIZE was set to 4 to maximize the performance when we do local performance testing with bench-tps. With the server side QOS restrictions per stake node and unstaked node, the benefit of more connections is less obvious while having more connections increase the load on the server especially during leader change.
This only change the default to 1. Validators still can use existing --tpu-connection-pool-size to override the default value.

Summary of Changes

Change DEFAULT_TPU_CONNECTION_POOL_SIZE to 1.

Fixes #


This is an automatic backport of pull request #1014 done by [Mergify](https://mergify.com).

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.6%. Comparing base (579f540) to head (6eb1a18).
Report is 1 commits behind head on v1.17.

Additional details and impacted files
@@            Coverage Diff            @@
##            v1.17    #1042     +/-   ##
=========================================
- Coverage    81.6%    81.6%   -0.1%     
=========================================
  Files         806      806             
  Lines      219332   219332             
=========================================
- Hits       179111   179103      -8     
- Misses      40221    40229      +8     

@t-nelson
Copy link

i'm gonna bow out of bp approval since i approved master

@lijunwangs lijunwangs merged commit 01c02f2 into v1.17 Apr 30, 2024
33 checks passed
@lijunwangs lijunwangs deleted the mergify/bp/v1.17/pr-1014 branch April 30, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants