v1.17 - Adds error log for replacements in ProgramCache::assign_program(). #1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lichtso
force-pushed
the
v1.17/program_cache_replacement_logs
branch
2 times, most recently
from
1e6ec94
to
5f90d34
Compare
Lichtso
force-pushed
the
v1.17/program_cache_replacement_logs
branch
from
5f90d34
to
722f1dd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v1.17 #1400 +/- ##
=======================================
Coverage 81.6% 81.6%
=======================================
Files 807 807
Lines 219370 219374 +4
=======================================
+ Hits 179087 179146 +59
+ Misses 40283 40228 -55 |
sakridge
approved these changes
May 17, 2024
t-nelson
approved these changes
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
These only exist on master and were not backported so far.
Summary of Changes
Adds error log for replacements in
ProgramCache::assign_program().