Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.17 - Adds error log for replacements in ProgramCache::assign_program(). #1400

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions program-runtime/src/loaded_programs.rs
Original file line number Diff line number Diff line change
Expand Up @@ -677,8 +677,13 @@ impl<FG: ForkGraph> LoadedPrograms<FG> {
(false, entry)
} else {
// Something is wrong, I can feel it ...
let existing = existing.clone();
error!(
"ProgramCache::assign_program() failed key={:?} existing={:?} entry={:?}",
key, slot_versions, entry
);
self.stats.replacements.fetch_add(1, Ordering::Relaxed);
(true, existing.clone())
(true, existing)
}
}
Err(index) => {
Expand All @@ -699,7 +704,7 @@ impl<FG: ForkGraph> LoadedPrograms<FG> {
entry: Arc<LoadedProgram>,
) -> (bool, Arc<LoadedProgram>) {
let (was_occupied, entry) = self.replenish(key, entry);
debug_assert!(!was_occupied);
debug_assert!(!was_occupied, "Unexpected replacement of an entry");
(was_occupied, entry)
}

Expand Down
1 change: 1 addition & 0 deletions runtime/src/bank.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5223,6 +5223,7 @@ impl Bank {
));

if programs_loaded_for_tx_batch.borrow().hit_max_limit {
error!("Discarding TX batch {:#?}", batch.sanitized_transactions());
return LoadAndExecuteTransactionsOutput {
loaded_transactions: vec![],
execution_results: vec![],
Expand Down
Loading