v1.17 - Add detailed metrics reporting for packet filtering #1422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstarry
force-pushed
the
v1.17-packet-filter-metrics
branch
from
6a0f612
to
c3c46da
Compare
apfitzge
approved these changes
May 17, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v1.17 #1422 +/- ##
=======================================
Coverage 81.6% 81.6%
=======================================
Files 807 808 +1
Lines 219370 219433 +63
=======================================
+ Hits 179097 179175 +78
+ Misses 40273 40258 -15 |
t-nelson
approved these changes
May 18, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We don't report metrics on how many packets are filtered out in banking stage for various reasons like sanitization failures, invalid compute, etc.
Summary of Changes
Report more metrics for different types of filtered packets
Manual backport of #1421