Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use bytemuck_derive 1.7.0 explicitly in sdk and program #1793

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

kevinheavey
Copy link

Problem

  • We are building an old version of bytemuck_derive that uses syn v1, meanwhile once [solana-program] Move bn254 logic from solana-program into a separate crate #1495 lands the only other thing in solana-program that uses syn v1 will be the optional borsh support. So removing syn v1 from solana-program will help compile times.
  • Using bytemuck_derive as a separate crate should also help compile times a bit by being more friendly to parallel builds. Also if we don't use bytemuck_derive explicitly it will look like an unused dependency.

Summary of Changes

  • Explicitly specify bytemuck_derive = "1.7.0" in Cargo.toml.
  • Use bytemuck_derive directly in solana-sdk and solana-program instead of using the derive feature of bytemuck.

Copy link

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! We could probably apply the same work to the rest of the repo, but I can do that in follow-up work

@joncinque joncinque merged commit 6cf3225 into anza-xyz:master Jun 20, 2024
52 checks passed
@kevinheavey kevinheavey deleted the bump-bytemuck-derive branch June 20, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants