deps: Use bytemuck_derive explicitly instead of "derive" feature on bytemuck #1799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bah sorry, none of my local testing is showing the issues coming up, setting this back to draft until I figure that out |
|
Ok this is all good now, sorry for the back and forth! |
kevinheavey
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As done in #1793, we can use
bytemuck_deriveexplicitly over enabling thederivefeature on the bytemuck crate.Summary of Changes
This continues the work from #1793 and removes all usage of the
derivefeature on the bytemuck crate.Fixes #