Move short_vec to its own crate #1796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinheavey
force-pushed
the
move-short-vec
branch
3 times, most recently
from
38d99e1
to
f2855fd
Compare
kevinheavey
force-pushed
the
move-short-vec
branch
5 times, most recently
from
970069d
to
0784367
Compare
kevinheavey
force-pushed
the
move-short-vec
branch
from
88e724e
to
0cfc712
Compare
buffalojoec
previously approved these changes
Jul 17, 2024
kevinheavey
force-pushed
the
move-short-vec
branch
from
0a8157d
to
94862ce
Compare
buffalojoec
approved these changes
Jul 17, 2024
kevinheavey
added
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
solana-program is bloated and short_vec.rs is easy to extract from it. This is a prerequisite for extracting solana-instruction and solana-message crates
Summary of Changes
Move short_vec.rs out of solana-program into a new crate
solana-short-vec.I have not re-exported solana-short-vec in solana-program or solana-sdk because I don't believe anyone uses it externally.I have re-exported solana-short-vec in solana-program and solana-sdk with a deprecation notice