Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corrected to not use hardcoded connections count for unstaked #633

Conversation

lijunwangs
Copy link

The max unstaked connections can be passed in value in spawn_server. This will make the QOS incorrectly accounting for the real passed in unstaked max connection count. This is used by jito-relayers.

Do not use the hardcoded one.

@lijunwangs
Copy link
Author

Hi @pgarg66 can you give this PR a review? Thanks

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.8%. Comparing base (01460ef) to head (a1a525b).
Report is 25 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #633   +/-   ##
=======================================
  Coverage    81.8%    81.8%           
=======================================
  Files         851      851           
  Lines      230238   230242    +4     
=======================================
+ Hits       188511   188550   +39     
+ Misses      41727    41692   -35     

@lijunwangs lijunwangs merged commit 592107a into anza-xyz:master Apr 9, 2024
38 checks passed
Copy link

mergify bot commented Apr 11, 2024

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

mergify bot pushed a commit that referenced this pull request Apr 11, 2024
* corrected to not use hardcoded connections count for unstaked

* Fixed a math problem on max_unstaked_load_in_throttling_window

* Fixed a unit test failure

(cherry picked from commit 592107a)
Copy link

mergify bot commented Apr 11, 2024

Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule.

mergify bot pushed a commit that referenced this pull request Apr 11, 2024
* corrected to not use hardcoded connections count for unstaked

* Fixed a math problem on max_unstaked_load_in_throttling_window

* Fixed a unit test failure

(cherry picked from commit 592107a)

# Conflicts:
#	streamer/src/nonblocking/quic.rs
#	streamer/src/nonblocking/stream_throttle.rs
lijunwangs pushed a commit that referenced this pull request Apr 11, 2024
…(backport of #633) (#734)

corrected to not use hardcoded connections count for unstaked (#633)
lijunwangs added a commit that referenced this pull request Apr 24, 2024
* corrected to not use hardcoded connections count for unstaked

* Fixed a math problem on max_unstaked_load_in_throttling_window

* Fixed a unit test failure

(cherry picked from commit 592107a)

# Conflicts:
#	streamer/src/nonblocking/quic.rs
#	streamer/src/nonblocking/stream_throttle.rs
lijunwangs added a commit that referenced this pull request Apr 30, 2024
* corrected to not use hardcoded connections count for unstaked

* Fixed a math problem on max_unstaked_load_in_throttling_window

* Fixed a unit test failure

(cherry picked from commit 592107a)

# Conflicts:
#	streamer/src/nonblocking/quic.rs
#	streamer/src/nonblocking/stream_throttle.rs
lijunwangs added a commit that referenced this pull request Apr 30, 2024
…(backport of #633) (#762)

* corrected to not use hardcoded connections count for unstaked (#633)

Co-authored-by: Lijun Wang <83639177+lijunwangs@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants