[SOL] add support for (pseudo) atomics to SBF #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lower atomic operations to their regular non-atomic equivalents. Lowering for all operations except atomic fence is done at DAG legalization time. Fences are removed at instruction emission time.
dmakarov
approved these changes
Jan 3, 2022
alessandrod
added a commit
to alessandrod/rust
that referenced
this pull request
Jan 3, 2022
(Pseudo) atomics are now implemented in SBF anza-xyz/llvm-project#23
alessandrod
added a commit
to anza-xyz/rust
that referenced
this pull request
Jan 3, 2022
(Pseudo) atomics are now implemented in SBF anza-xyz/llvm-project#23
dmakarov
pushed a commit
to dmakarov/llvm-project
that referenced
this pull request
Feb 28, 2022
Lower atomic operations to their regular non-atomic equivalents. Lowering for all operations except atomic fence is done at DAG legalization time. Fences are removed at instruction emission time.
dmakarov
pushed a commit
to dmakarov/rust
that referenced
this pull request
Mar 22, 2022
(Pseudo) atomics are now implemented in SBF anza-xyz/llvm-project#23
dmakarov
pushed a commit
to dmakarov/llvm-project
that referenced
this pull request
Jul 18, 2022
Lower atomic operations to their regular non-atomic equivalents. Lowering for all operations except atomic fence is done at DAG legalization time. Fences are removed at instruction emission time.
dmakarov
pushed a commit
to dmakarov/rust
that referenced
this pull request
Jul 27, 2022
(Pseudo) atomics are now implemented in SBF anza-xyz/llvm-project#23
dmakarov
pushed a commit
to dmakarov/llvm-project
that referenced
this pull request
Nov 16, 2022
Lower atomic operations to their regular non-atomic equivalents. Lowering for all operations except atomic fence is done at DAG legalization time. Fences are removed at instruction emission time.
dmakarov
pushed a commit
to dmakarov/rust
that referenced
this pull request
Dec 6, 2022
(Pseudo) atomics are now implemented in SBF anza-xyz/llvm-project#23
dmakarov
pushed a commit
to dmakarov/llvm-project
that referenced
this pull request
Dec 12, 2022
Lower atomic operations to their regular non-atomic equivalents. Lowering for all operations except atomic fence is done at DAG legalization time. Fences are removed at instruction emission time.
dmakarov
pushed a commit
to dmakarov/llvm-project
that referenced
this pull request
Mar 17, 2023
Lower atomic operations to their regular non-atomic equivalents. Lowering for all operations except atomic fence is done at DAG legalization time. Fences are removed at instruction emission time.
dmakarov
pushed a commit
to dmakarov/rust
that referenced
this pull request
Mar 18, 2023
(Pseudo) atomics are now implemented in SBF anza-xyz/llvm-project#23
dmakarov
pushed a commit
to dmakarov/llvm-project
that referenced
this pull request
Sep 10, 2023
Lower atomic operations to their regular non-atomic equivalents. Lowering for all operations except atomic fence is done at DAG legalization time. Fences are removed at instruction emission time.
dmakarov
pushed a commit
to dmakarov/rust
that referenced
this pull request
Sep 25, 2023
(Pseudo) atomics are now implemented in SBF anza-xyz/llvm-project#23
LucasSte
pushed a commit
to LucasSte/llvm-project
that referenced
this pull request
Jan 31, 2024
Lower atomic operations to their regular non-atomic equivalents. Lowering for all operations except atomic fence is done at DAG legalization time. Fences are removed at instruction emission time.
LucasSte
pushed a commit
to LucasSte/rust
that referenced
this pull request
Feb 1, 2024
(Pseudo) atomics are now implemented in SBF anza-xyz/llvm-project#23
LucasSte
pushed a commit
that referenced
this pull request
Feb 16, 2024
Lower atomic operations to their regular non-atomic equivalents. Lowering for all operations except atomic fence is done at DAG legalization time. Fences are removed at instruction emission time.
LucasSte
pushed a commit
to LucasSte/rust
that referenced
this pull request
Feb 19, 2024
(Pseudo) atomics are now implemented in SBF anza-xyz/llvm-project#23
LucasSte
pushed a commit
to anza-xyz/rust
that referenced
this pull request
Feb 20, 2024
(Pseudo) atomics are now implemented in SBF anza-xyz/llvm-project#23
LucasSte
pushed a commit
to LucasSte/llvm-project
that referenced
this pull request
Jun 28, 2024
Lower atomic operations to their regular non-atomic equivalents. Lowering for all operations except atomic fence is done at DAG legalization time. Fences are removed at instruction emission time.
LucasSte
pushed a commit
to LucasSte/rust
that referenced
this pull request
Jul 10, 2024
(Pseudo) atomics are now implemented in SBF anza-xyz/llvm-project#23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lower atomic operations to their regular non-atomic equivalents. Lowering for all operations except atomic fence is done at DAG legalization time. Fences are removed at instruction emission time. The custom lowering is done only for the SBF subtarget, BPF atomics still work (and tests still pass).
This will allow us to remove all the atomic stubs we have behind
#[cfg(target_arch = "sbf")]in rustc, and implements some things we hadn't stubbed yet, making all atomics test pass.