Remove stubs for atomics #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmakarov
approved these changes
Jan 3, 2022
| @@ -2770,16 +2670,7 @@ unsafe fn atomic_umin<T: Copy + crate::cmp::Ord>(dst: *mut T, val: T, _order: Or | |||
| #[inline] | |||
| #[stable(feature = "rust1", since = "1.0.0")] | |||
| #[rustc_diagnostic_item = "fence"] | |||
| #[cfg_attr(any(target_arch = "bpf", target_arch = "sbf", target_arch = "wasm32"), allow(unused_variables))] | |||
There was a problem hiding this comment.
Shouldn't this remain for target_arch = "wasm32"?
There was a problem hiding this comment.
Upstream doesn't seem to have it - is it something you somehow ran into? If it's something we added, it'd be great if we upstreamed it! But I don't think it makes much sense to keep it in our solana-* branches since we're not building wasm
There was a problem hiding this comment.
I didn't check upstream. I thought we had from upstream. In this case, sure, let's remove it altogether.
| pub fn fence(order: Ordering) { | ||
| #[cfg(not(any(target_arch = "wasm32", target_arch = "bpf", target_arch = "sbf")))] |
There was a problem hiding this comment.
Maybe keep the condition and comment for (not(target_arch = "wasm32"))?
alessandrod
force-pushed
the
sol/atomics
branch
from
c773bfd
to
e4df383
Compare
(Pseudo) atomics are now implemented in SBF anza-xyz/llvm-project#23
alessandrod
force-pushed
the
sol/atomics
branch
from
e4df383
to
9ea8ef6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Pseudo) atomics are now implemented in SBF anza-xyz/llvm-project#23. The PR also enables atomic tests, and with those, now all core tests pass ✅