This repository has been archived by the owner on Mar 20, 2024. It is now read-only.
Refactor ir-tests #115
Merged
Refactor ir-tests #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! i'll put my patches after this has landed. LGTM but i'd wait for pre-merge checks to come clean. |
ksolana
approved these changes
May 2, 2023
- use test_common::get_harness_paths in ir-tests instead of defining another copy of nearly the same function. - run a builder for move-compiler and move-ir-compiler before getting the paths of these dependencies in get_harness_paths
ksolana
pushed a commit
to ksolana/move
that referenced
this pull request
Jun 24, 2023
ksolana
pushed a commit
to ksolana/move
that referenced
this pull request
Jul 6, 2023
ksolana
pushed a commit
that referenced
this pull request
Jul 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50
Motivation
Remove duplication in test harness code. Automate building of dependencies currently built manually.
Have you read the Contributing Guidelines on pull requests?
Yes