This repository has been archived by the owner on Mar 20, 2024. It is now read-only.
Fix another move-native fmt::Debug crash (vector-of-structs). #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thi patch fixes another occurrence in the move-native runtime library defect where a debug formatter-- this time in the vector-of-structs case-- dereferenced and called a rogue pointer. This results in a callx out of the address space. anza-xyz#191. Also enhanced the fmt::Debug routines for structs to output the struct name and otherwise make the output more like what a default rust debug formatter for structs would do. Other minor NFC clean-ups. Added a runnable rbpf test cases demonstrating vector-of-struct operations and debug-printing. Updated the log messages of the other rtty tests since the output now includes names.
ksolana
pushed a commit
to ksolana/move
that referenced
this pull request
Jun 24, 2023
…yz#194) This patch fixes another occurrence of the move-native runtime defect where a debug formatter-- this time in the vector-of-structs case-- dereferenced and called a rogue pointer. This results in a callx out of the address space. anza-xyz#191. Also enhanced the fmt::Debug routines for structs to output the struct name and otherwise make the output more like what a default rust debug formatter for structs would do. Other minor NFC clean-ups. Added a runnable rbpf test cases demonstrating vector-of-struct operations and debug-printing. Updated the log messages of the other rtty tests since the output now includes names.
ksolana
pushed a commit
to ksolana/move
that referenced
this pull request
Jul 6, 2023
…yz#194) This patch fixes another occurrence of the move-native runtime defect where a debug formatter-- this time in the vector-of-structs case-- dereferenced and called a rogue pointer. This results in a callx out of the address space. anza-xyz#191. Also enhanced the fmt::Debug routines for structs to output the struct name and otherwise make the output more like what a default rust debug formatter for structs would do. Other minor NFC clean-ups. Added a runnable rbpf test cases demonstrating vector-of-struct operations and debug-printing. Updated the log messages of the other rtty tests since the output now includes names.
ksolana
pushed a commit
that referenced
this pull request
Jul 17, 2023
This patch fixes another occurrence of the move-native runtime defect where a debug formatter-- this time in the vector-of-structs case-- dereferenced and called a rogue pointer. This results in a callx out of the address space. #191. Also enhanced the fmt::Debug routines for structs to output the struct name and otherwise make the output more like what a default rust debug formatter for structs would do. Other minor NFC clean-ups. Added a runnable rbpf test cases demonstrating vector-of-struct operations and debug-printing. Updated the log messages of the other rtty tests since the output now includes names.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes another occurrence of the move-native runtime defect where a debug formatter-- this time in the vector-of-structs case-- dereferenced and called a rogue pointer. This results in a callx out of the address space. #191.
Also enhanced the fmt::Debug routines for structs to output the struct name and otherwise make the output more like what a default rust debug formatter for structs would do.
Other minor NFC clean-ups.
Added a runnable rbpf test cases demonstrating vector-of-struct operations and debug-printing. Updated the log messages of the other rtty tests since the output now includes names.