This repository has been archived by the owner on Mar 20, 2024. It is now read-only.
Implement vector-of-vector comparison in move-native.
#226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch extends the baseline `move-native` `vec_cmp_eq` routine to handle vector<vector<T>>. Uncomment `test_vec_vec_bool` in the stdlib-bcs serializer test (which now passes). Add more tests to vec.move to exercise vec_cmp_eq with vec-of-vec.
ksolana
pushed a commit
that referenced
this pull request
Jul 17, 2023
This patch extends the baseline `move-native` `vec_cmp_eq` routine to handle vector<vector<T>>. Uncomment `test_vec_vec_bool` in the stdlib-bcs serializer test (which now passes). Add more tests to vec.move to exercise vec_cmp_eq with vec-of-vec.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch extends the baseline
move-nativevec_cmp_eqroutine to handlevector<vector<T>>.Uncomment
test_vec_vec_boolin the stdlib-bcs serializer test (which now passes).Add more tests to
vec.moveto exercise vec_cmp_eq with vec-of-vec.