Skip to content
This repository has been archived by the owner on Mar 20, 2024. It is now read-only.

Upgrade llvm-sys to 17.0.1 #435

Merged
merged 3 commits into from Mar 14, 2024
Merged

Upgrade llvm-sys to 17.0.1 #435

merged 3 commits into from Mar 14, 2024

Conversation

ksolana
Copy link
Collaborator

@ksolana ksolana commented Mar 13, 2024

Fixes: #431

@ksolana ksolana force-pushed the llvm-sys-17 branch 2 times, most recently from 38394a1 to aa6b5b0 Compare March 13, 2024 17:52
@ksolana ksolana force-pushed the llvm-sys-17 branch 3 times, most recently from d301313 to 34889b6 Compare March 14, 2024 06:44
@brson
Copy link
Collaborator

brson commented Mar 14, 2024

Oof, I just merged @jcivlin's #436, and it seems perhaps that broke tests here.

This seems good to me though.

@ksolana
Copy link
Collaborator Author

ksolana commented Mar 14, 2024

no worries i'll fix it forward.

@jcivlin
Copy link
Collaborator

jcivlin commented Mar 14, 2024

Oof, I just merged @jcivlin's #436, and it seems perhaps that broke tests here.

This seems good to me though.

Lines in debug_info depend on llvm_sys versions. Both are correct and the diff is very light (so far), but since we do a literal comparison the tests fail.
All is needed it the update of expected files.
I would work on a filter in test comparison to make it less version dependent, but I do not know what will change or stay.

@ksolana ksolana merged commit f1fc21c into anza-xyz:llvm-sys Mar 14, 2024
7 checks passed
@ksolana ksolana deleted the llvm-sys-17 branch March 14, 2024 15:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use llvm-sys 17 or newer
4 participants