[SOL] Set 32 bits for SBF minimum enum size #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucasSte
changed the title
dmakarov
approved these changes
Feb 23, 2024
LucasSte
changed the title
LucasSte
changed the title
This was referenced Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
#[repr(C]on an enum in Rust, its size used to be 32-bits. However, rust-lang#107592 changed it to the target'sc_intsize, which is 64-bits for SBF.As a consequence, the enum size is inconsistent between versions of the platform tools. A
#[repr(C)]enum was 4 bytes in v1.37 and became 8 bytes in v1.39. This PR sets the enum size for 32-bits in SBF, as it used to be before the change.