Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: customise header link(s) #1847

Closed
markhepburn opened this issue Jul 22, 2015 · 5 comments
Closed

Feature Request: customise header link(s) #1847

markhepburn opened this issue Jul 22, 2015 · 5 comments
Labels
enhancement

Comments

@markhepburn
Copy link
Contributor

The portal has basic branding support, including footer content, header text, and css overrides.

It would be nice if we could also customise the links in the top right corner via the same mechanism. Our motivation is just to have our own help page, explaining the provenance etc before pointing off to the official manual on aodn.org.au.

(I'm happy to put together a PR some time if you'd look at that)
@dnahodil
Copy link
Contributor

Hey @markhepburn,

The links in the top right can be customised, currently. The config just lets you add links, nothing fancier than that, but it sounds like that'll be enough for your needs. Check out

aodn-portal/grails-app/conf/Config.groovy

Line 230 in 182b0ac

externalLinks = [
(sing out if you need help getting it to work).

Cheers,

@dnahodil
Copy link
Contributor

I've just seen that we've removed that customisation 😞 (but didn't remove the config entry)

Maybe try reverting this commit 44895d2 and if that seems to work (and is configurable as you need) you can put up a PR for that.

@markhepburn
Copy link
Contributor Author

Thanks @dnahodil , incoming shortly.

markhepburn added a commit to IMASau/aodn-portal that referenced this issue Jul 29, 2015
@markhepburn
Revert 44895d2; make help links configurable
691b49e 
Had to do this manually, rather than git-revert.  See
aodn#1847.

Will need a corresponding change to the chef recipe if generating the
config file that way.
@markhepburn markhepburn mentioned this issue Jul 29, 2015
Merged
@dnahodil
Copy link
Contributor

👍

@dnahodil dnahodil closed this as completed Aug 3, 2015
@dnahodil
Copy link
Contributor

dnahodil commented Aug 3, 2015

Works on master, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@markhepburn @danfruehauf @dnahodil