Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EchoIntensitySetQC & imosSurfaceDetectionByDepthQC broken since 2.6.12 #742

Closed
3 tasks done
ocehugo opened this issue May 28, 2021 · 1 comment
Closed
3 tasks done

EchoIntensitySetQC & imosSurfaceDetectionByDepthQC broken since 2.6.12 #742

ocehugo opened this issue May 28, 2021 · 1 comment
Labels
Type:bug Something is missing or wrong Unit:QC Quality control related

Comments

@ocehugo
Copy link
Contributor

ocehugo commented May 28, 2021 •
edited
Loading

Release 2.6.12 broke some case handling in the new EchoIntensitySetQC and imosSurfaceDetectionByDepthQC.

The fix in 2.6.12 turned the logic handling of DIST_ALONG_BEAMS and HEIGHT_ABOVE_SENSOR invalid in these functions and they are now skipped/do not perform any action. two tests failed, but I somehow ignored them or I skipped running before the hot-fix.

  • Logic is updated
  • One extra missing tests is available
  • Fix test handling
@ocehugo ocehugo added Type:bug Something is missing or wrong Unit:QC Quality control related labels May 28, 2021
ocehugo added a commit that referenced this issue Jun 10, 2021
@ocehugo
fix(QC): EchoIntensitySet SurfaceDetectionByDepth
67e52fb 
This commit fixes the no-op for the
`imosEchoIntensitySetQC` & `imosSurfaceDetectionByDepthSetQC`
bug introduced at version 2.6.12. See #742.

The handling order of ADCP beam/height dimensions in
these routines became incompatible after the changes
introduced. The outdated code assumptions caused
QC routines to be skipped for most cases.

The problem was both in the order of dimension checking
and the weak detection of a "original" along beam
adcp dataset.

Before, we defined an original beam dataset
as one containing "DIST_ALONG_BEAMS". However,
this is too lenient since some converted
coordinates datasets still need to keep
this dimension even after conversion to
height above sensor.

See also `IMOS.adcp.is_along_beam`.

Two new tests - one for each QC -  are now
available to avoid future regressions.
@ocehugo
Copy link
Contributor Author

ocehugo commented Jun 10, 2021

closed by 67e52fb

@ocehugo ocehugo closed this as completed Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type:bug Something is missing or wrong Unit:QC Quality control related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ocehugo