Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge EagerFutureStream and SimpleReactStream, remove time based operators from EagerFutureStream #44

Closed
johnmcclean opened this issue Aug 7, 2015 · 1 comment
Labels
Milestone

Comments

@johnmcclean
Copy link
Member

Eager Streams (EagerFutureStream and SimpleReactStream) perform a terminal operation on the underlying Stream at each phase, this means for any (more complex) operators (see list of operators that are batched for EagerFuturestream) that require data to flow though a queue they need to pull all data in from that Queue before the subsequent stages can be started (in other words data must flow through the queue to the next stage as a batch).

This makes time based operators such as batchByTime, jitter, debounce, chunked etc. less useful than for LazyFutureStreams. Reducing the operator set for EagerFutureStream would reduce the gap between it and SimpleReactStream - and perhaps they should be merged, leaving 2 streams

LazyFutureStream for infinite async streaming
and
EagerFutureStream, simpler API, for processing of small batches

@johnmcclean johnmcclean added the bug label Aug 7, 2015
@johnmcclean johnmcclean added this to the 0.99 milestone Aug 7, 2015
@johnmcclean
Copy link
Member Author

Keep separate, with better implementations for batchBySize, batchByTime, batchByTimeAndSize, debounce for EFS - v0.99 branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant